program: add get_worst_case_base_asset_amount for spot to reduce cu's in place_spot_order #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wphan
approved these changes
Oct 23, 2023
0xbigz
reviewed
Oct 24, 2023
| @@ -309,7 +309,7 @@ pub fn place_perp_order( | |||
| )?; | |||
| } | |||
|
|
|||
| if force_reduce_only && risk_increasing { | |||
| if force_reduce_only && !user.orders[new_order_index].reduce_only { | |||
There was a problem hiding this comment.
so if a market is in reduce only mode, a user's order will fail without explicitly setting reduce only flag?
There was a problem hiding this comment.
feel like a method is_reducing() would be nicer?
There was a problem hiding this comment.
is_reducing on what? above if the force_reduce_only is true, the order param is forced to be true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.