program: liquidate spot with swap #1402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return Err(ErrorCode::InvalidLiquidation); | ||
| } | ||
|
|
||
| validate!( |
There was a problem hiding this comment.
do we want to fail the tx here or allow the swap up to the max?
| msg!("margin calculation: {:?}", margin_calculation); | ||
| return Err(ErrorCode::SufficientCollateral); | ||
| } else if user.is_being_liquidated() && margin_calculation.can_exit_liquidation()? { | ||
| user.exit_liquidation(); |
There was a problem hiding this comment.
will user still exit liquidation if error is returned right after?
| let asset_precision = 10_u128.pow(asset_decimals); | ||
| let liability_precision = 10_u128.pow(liability_decimals); | ||
|
|
||
| let swap_price = liability_transfer |
There was a problem hiding this comment.
can we use the calculate swap price func from here for consistency?
wphan
reviewed
Jan 3, 2025
| liability_transfer.safe_sub(if_fee)?, | ||
| &SpotBalanceType::Deposit, | ||
| &mut liability_market, | ||
| user.get_spot_position_mut(liability_market_index)?, |
There was a problem hiding this comment.
maybe instead of explicit open position checks (which look missing here) we can use .expect here so bots dont get a generic error.
| { | ||
| let mut liability_market = spot_market_map.get_ref_mut(&liability_market_index)?; | ||
|
|
||
| update_spot_balances_and_cumulative_deposits( |
There was a problem hiding this comment.
do you need to call update_spot_balances_and_cumulative_deposits for the liquidator?
| pub fn liquidate_spot_with_swap_begin( | ||
| asset_market_index: u16, | ||
| liability_market_index: u16, | ||
| swap_amount: u64, |
| pub fn handle_liquidate_spot_with_swap_end<'c: 'info, 'info>( | ||
| ctx: Context<'_, '_, 'c, 'info, LiquidateSpotWithSwap<'info>>, | ||
| asset_market_index: u16, | ||
| liability_market_index: u16, |
There was a problem hiding this comment.
would it be a good idea to add min_amount_out so liquidator has some control over worst case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.