sdk: fix leverage after trade bug (#674)

* sdk: fix leverage after trade bug * use worstCaseBase
drift-labs · Nov 6, 2023 · 6e5530f · 6e5530f
1 parent 6205213
commit 6e5530f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Features
 
 ### Fixes
+- sdk: fix bug which incorrectly calculated leverage after trade for a market with no position but short orders open
 
 ### Breaking
 

diff --git a/sdk/src/user.ts b/sdk/src/user.ts
@@ -2884,8 +2884,12 @@ export class User {
 			includeOpenOrders
 		);
 
+		const worstCaseBase = calculateWorstCaseBaseAssetAmount(currentPosition);
+
+		// current side is short if position base asset amount is negative OR there is no position open but open orders are short
 		const currentSide =
-			currentPosition && currentPosition.baseAssetAmount.isNeg()
+			currentPosition.baseAssetAmount.isNeg() ||
+			(currentPosition.baseAssetAmount.eq(ZERO) && worstCaseBase.isNeg())
 				? PositionDirection.SHORT
 				: PositionDirection.LONG;