feature: Canon Raw V3 support via MP4 handlers #644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drewnoakes - what do you think about the addition of another
At the moment, this would only give us a single property for the directory - I don't think I'd be able to provide anything meaningful for the other sub-tags, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate to #624 , solving the same original feature request: #374
Since we already have an Mp4UuidBoxHandler, I followed @TSGames' approach, but registered the special handling under the apparently unique Canon Raw V3 UUID, adding to the enumeration. This routes the 4 "Canon Metadata in TIFF format" sub-tags to our existing handlers.
note: I tried locating a better dictionary entry for
crx(to complete the major/compatible brands, but didn't find any usage.