Added code to parse OM System II makernote (uses Olympus II makernote) #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
reviewed
Dec 15, 2023
| @@ -459,6 +460,12 @@ private boolean processMakernote(final int makernoteOffset, | |||
| // http://exiv2.org/makernote.html | |||
| pushDirectory(OlympusMakernoteDirectory.class); | |||
| TiffReader.processIfd(this, reader, processedIfdOffsets, makernoteOffset + 12, makernoteOffset); | |||
| } else if ("OM SYSTEM\0\0\0II".equals(firstFourteenChars)) { | |||
There was a problem hiding this comment.
The II suggests Intel byte ordering. Do we know if there's a similar MM variant for Motorola order?
There was a problem hiding this comment.
Not that I know of - this pattern matches all the photos I've taken with my OM1. I was under the assumption that the 'II' stood for the same indicator that the makernote was the Olympus second version since OM system bought the imaging division of Olympus and just stuck the new signature there.
drewnoakes
approved these changes
Dec 15, 2023
|
Relates to drewnoakes/metadata-extractor-dotnet#354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to parse OM System II makernote (uses Olympus II makernote) by checking the signature in ProcessMakernote (matches andydragon/omsystem PR in metadata-extractor-dotnet and andydragon/omsystem PR in metadata-extractor-images)