Nikon PictureControl directory extraction #634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ports the change that were made on C# repo to this Java repo. https://github.com/drewnoakes/metadata-extractor-dotnet/pull/341/files
|
@drewnoakes please review and merge/release this. The image files that i used are from https://github.com/drewnoakes/metadata-extractor-images/wiki/ContentSummary. Let me know if there's an easier way to crop/resize those images to low resolution and preserve all the metadata. |
|
I added the tests back with APP1 segment data created using ExtractJpegSegmentTool. |
|
Please remove all test data and unit tests and squash history. We use the regression test suite for this as it's more comprehensive, has better ergonomics, and allows comparison between Java and .NET implementations. |
added 4 commits
November 15, 2023 15:54
This PR ports the change that were made on C# repo to this Java repo. https://github.com/drewnoakes/metadata-extractor-dotnet/pull/341/files
… into NikonPictureControl1And2Directory
|
Will open new PR with squashed commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the change that were made on C# repo to this Java repo.
https://github.com/drewnoakes/metadata-extractor-dotnet/pull/341/files