-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1/4 TIFF processing simplification by 'shifting' base of random access reader #581
base: main
Are you sure you want to change the base?
Conversation
(not ready yet, I got test failures to fix) |
Looking good so far. The best way to validate correctness is to clone https://github.com/drewnoakes/metadata-extractor-images and run your updated code against all those files to check for regressions. It's not a process I've documented, sorry, so I can do that for you if you like, but doing it yourself would give you a tighter feedback loop. |
@drewnoakes thank you! I'll do it :) And probably create a PR to improve the documentation as well :) |
Here's an overview of the process.
|
0d4d9f9
to
a18b83d
Compare
thank you! now the PR is ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks very much for these nicely structured PRs. It makes them very easy to review, which I appreciate.
I'm adding some comments with initial thoughts to your PRs. Don't feel you have to take any action on them, especially as changes to the first PR require rebasing other PRs etc. I'm going to pull down all your changes locally and try them out. I can make small tweaks in an additional commit at the end if needed. The comments on your PRs are just my notes and thoughts rather than requests of you.
… than passing TIFF header offsets around everywhere.
a18b83d
to
3a975db
Compare
This is the first step towards solving #278
Port of this commit: drewnoakes/metadata-extractor-dotnet@2281cea