Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed regex in deployment branches filter #1263

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

ivangrynenko
Copy link
Contributor

@ivangrynenko ivangrynenko commented Apr 12, 2024

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. It seems the regex for filter branches is not valid.

Screenshots

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.47%. Comparing base (0f042b2) to head (bf25a9c).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1263       +/-   ##
============================================
- Coverage    68.35%   44.47%   -23.88%     
============================================
  Files           50       50               
  Lines         3087     3087               
============================================
- Hits          2110     1373      -737     
- Misses         977     1714      +737     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk enabled auto-merge (squash) April 12, 2024 08:03
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivangrynenko Thank you for your contribution!

@AlexSkrypnyk AlexSkrypnyk merged commit ce3331c into drevops:develop Apr 16, 2024
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released in 1.20
Development

Successfully merging this pull request may close these issues.

2 participants