Support extra_chain_cert= setting #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marshall-lee why is this PR for net-http-persistent and not net-http? (i didn't see any context regarding that in the linked bug, sorry if i'm missing something) |
marshall-lee
force-pushed
the
extra_chain_cert
branch
from
8435d9f to
455426e
Compare
|
The problem is that |
|
ping @tenderlove |
|
We need to figure out a way to automatically do this so that we don't have to change net-http-persistent every time net-http changes. 🥲 |
|
Shipped this in 4.0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://bugs.ruby-lang.org/issues/9758