Skip to content

Commit

Permalink
Remove superfluous permissions on Android
Browse files Browse the repository at this point in the history
Camera, microphone and legacy external storage permission depending on
the Android version.

Fixes #1405.
  • Loading branch information
askmeaboutlo0m committed Nov 17, 2024
1 parent b3e7c8f commit b17ba09
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
1 change: 1 addition & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Unreleased Version 2.2.2-pre
* Fix: Don't use bilinear interpolation in transforms unnecessarily.
* Feature: Add canvas shortcuts for changing color hue, saturation/chroma and value/lightness/luminosity. Thanks Dann DecCairns for suggesting.
* Feature: Make size adjustment canvas shortcut depend on the speed of the drag. Thanks MorrowShore for suggesting.
* Fix: Remove pointless permissions on Android that Qt includes by default but aren't actually used.

2024-11-06 Version 2.2.2-beta.4
* Fix: Solve rendering glitches with selection outlines that happen on some systems. Thanks xxxx for reporting.
Expand Down
14 changes: 12 additions & 2 deletions src/desktop/AndroidManifest.xml.in
Original file line number Diff line number Diff line change
@@ -1,13 +1,23 @@
<?xml version="1.0"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
<manifest
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="${ANDROID_PACKAGE_NAMESPACE}"
android:installLocation="auto"
android:versionCode="${DRAWPILE_ANDROID_VERSION_CODE}"
android:versionName="${PROJECT_VERSION}">
<!-- %%INSERT_PERMISSIONS -->
<!-- INTERNET is required to open TCP connections. -->
<uses-permission android:name="android.permission.INTERNET" />
<!-- ACCESS_NETWORK_STATE is required by Qt somehow. Not sure what for. -->
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
<!-- WAKE_LOCK is used to prevent the device from severing the connection to
the server by sleeping when it is locked -->
<uses-permission android:name="android.permission.WAKE_LOCK" />
<!-- WRITE_EXTERNAL_STORAGE only does something on older Android. -->
<uses-permission
android:name="android.permission.WRITE_EXTERNAL_STORAGE"
android:maxSdkVersion="29"
tools:ignore="ScopedStorage" />
<!-- %%INSERT_FEATURES -->
<supports-screens
android:anyDensity="true"
Expand Down

0 comments on commit b17ba09

Please sign in to comment.