Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add support for linking to shared falcosecurity libraries. #2093

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Apteryks
Copy link

@Apteryks Apteryks commented May 8, 2024

  • cmake/modules/falcosecurity-libs.cmake (USE_BUNDLED_FALCOSECURITY_LIBS): New option. Look for libsinsp via pkg-config unless it's enabled.
  • userspace/sysdig/CMakeLists.txt: Adjust link directives accordingly. Remove extraneous zlib include.

@Apteryks Apteryks requested a review from therealbobo as a code owner May 8, 2024 02:43
userspace/sysdig/CMakeLists.txt Outdated Show resolved Hide resolved
@Apteryks
Copy link
Author

Apteryks commented May 9, 2024

Note that this depends on falcosecurity/libs#1842 to work.

* cmake/modules/falcosecurity-libs.cmake (USE_BUNDLED_FALCOSECURITY_LIBS):
New option.  Look for libsinsp via pkg-config unless it's enabled.
* userspace/sysdig/CMakeLists.txt: Adjust link directives accordingly.
Remove extraneous zlib include.

Signed-off-by: Maxim Cournoyer <[email protected]>
@Apteryks Apteryks force-pushed the support-shared-falcosecurity-libs branch from 9327969 to 35ea4d3 Compare May 19, 2024 01:01
Copy link

sonarcloud bot commented May 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Apteryks Apteryks requested a review from therealbobo May 19, 2024 01:42
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 16, 2024
@Apteryks
Copy link
Author

Not stale (that's an aggressive bot!).

@github-actions github-actions bot removed the stale label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants