aws - security-group - references ingress/egress rules bug fix (cloud…

…-custodian#6838)
draios · Aug 5, 2021 · 232de1b · 232de1b
1 parent a224d27
commit 232de1b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/c7n/resources/vpc.py b/c7n/resources/vpc.py
@@ -1211,7 +1211,7 @@ def process_sg_references(self, perm, owner_id):
  if not sg_perm:
  return False
 
- sg_group_ids = [p['GroupId'] for p in sg_perm if p['UserId'] == owner_id]
+ sg_group_ids = [p['GroupId'] for p in sg_perm if p.get('UserId', '') == owner_id]
  sg_resources = self.manager.get_resources(sg_group_ids)
  vf = ValueFilter(sg_refs, self.manager)
  vf.annotate = False

diff --git a/tests/test_vpc.py b/tests/test_vpc.py
@@ -2196,7 +2196,6 @@ def test_security_group_reference_ingress_filter(self):
  session_factory=factory,
  )
  resources = p.run()
-
  self.assertEqual(len(resources), 1)
 
  def test_security_group_reference_egress_filter(self):
@@ -2219,7 +2218,6 @@ def test_security_group_reference_egress_filter(self):
  session_factory=factory,
  )
  resources = p.run()
-
  self.assertEqual(len(resources), 1)
 
  def test_egress_ipv6(self):