-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add E2E tests for cases that peers going offline #3524
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3524 +/- ##
==========================================
+ Coverage 35.93% 36.04% +0.11%
==========================================
Files 335 335
Lines 36848 36961 +113
==========================================
+ Hits 13240 13323 +83
- Misses 22769 22801 +32
+ Partials 839 837 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bd92139
to
4eab162
Compare
0132600
to
a86b706
Compare
20e1822
to
927e11d
Compare
440c820
to
9c337da
Compare
59d4c1c
to
65ed5f8
Compare
Signed-off-by: BruceAko <[email protected]>
Signed-off-by: BruceAko <[email protected]>
Signed-off-by: BruceAko <[email protected]>
511613d
to
dd8ba10
Compare
Signed-off-by: BruceAko <[email protected]>
All problems resolved, please take a look, thanks. @gaius-qi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Verifies that Scheduler can clear offline peer metadata when the host exits normally/abnormally by following steps:
Related Issue
close #3523
Motivation and Context
Earlier we have added functionality so that hosts send
LeaveHost()
requests to the Scheduler on normal exit and hosts on abnormal exit are also sensed by the Scheduler GC after a set amount of time and the metadata is cleared. Now, we are going to add E2E tests to verify that this functionality is correct.Types of changes
Checklist