Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.9 and 3.10 #111

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Support Python 3.9 and 3.10 #111

wants to merge 5 commits into from

Conversation

matt-peters
Copy link
Collaborator

@matt-peters matt-peters commented Nov 18, 2022

Adds support for newer versions of Python and sklearn > 1.0.0.

Fixes #110 #101 #109 #107

@rashadmoarref
Copy link

It'd be great if this PR gets some attention. I have verified that this branch builds on Python3.9 using below pre-requirements:

lxml==4.9.2
numpy==1.20.3
Cython==0.29.33

and that the default extract_content method works properly using below dependency versions:

joblib==1.2.0
scikit-learn==1.1.2

@ericluugg
Copy link

For anyone interested I've forked a 3.10 branch https://github.com/ericluugg/dragnet3.10

This is the highest I've been able to get the dependencies. Anything past scikit-learn 1.2.2 leads to errors unpickling old models

lxml==5.1.1
numpy==1.26.3
Cython==3.0.10
scipy==1.14.0
scikit-learn==1.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is this project maintained?
3 participants