Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Differential ShellCheck #2530

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,33 @@ jobs:
- name: shfmt
uses: luizm/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SHFMT_OPTS: -s # arguments to shfmt.
with:
sh_checker_shellcheck_disable: false
sh_checker_comment: true
sh_checker_shellcheck_disable: true # disable shellcheck in favor of differential-shellcheck

differential-shellcheck:
runs-on: ubuntu-latest

permissions:
security-events: write

steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0

- id: ShellCheck
name: Differential ShellCheck
uses: redhat-plumbers-in-action/differential-shellcheck@v5
with:
token: ${{ secrets.GITHUB_TOKEN }}

- if: ${{ always() }}
name: Upload artifact with ShellCheck defects in SARIF format
uses: actions/upload-artifact@v3
with:
name: Differential ShellCheck SARIF
path: ${{ steps.ShellCheck.outputs.sarif }}

lint-c:
runs-on: ubuntu-latest
Expand Down
8 changes: 6 additions & 2 deletions AUTHORS
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Harald Hoyer <[email protected]>
Victor Lowther <[email protected]>
Jóhann B. Guðmundsson <[email protected]>
Antonio Alvarez Feijoo <[email protected]>
Jóhann B. Guðmundsson <[email protected]>
Laszlo Gombos <[email protected]>
Amadeusz Żołnowski <[email protected]>
Daniel Molkentin <[email protected]>
Expand Down Expand Up @@ -76,6 +76,7 @@ Radek Vykydal <[email protected]>
Zbigniew Jędrzejewski-Szmek <[email protected]>
Đoàn Trần Công Danh <[email protected]>
Fabian Deutsch <[email protected]>
Jan Macku <[email protected]>
Kamil Rytarowski <[email protected]>
Lidong Zhong <[email protected]>
Marc Grimme <[email protected]>
Expand Down Expand Up @@ -128,6 +129,7 @@ Thomas Backlund <[email protected]>
Topi Miettinen <[email protected]>
Vasiliy Tolstov <[email protected]>
Wim Muskee <[email protected]>
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
keentux <[email protected]>
Alan Jenkins <[email protected]>
Alan Pevec <[email protected]>
Expand Down Expand Up @@ -156,7 +158,6 @@ Hari Bathini <[email protected]>
Ian Dall <[email protected]>
Imran Haider <[email protected]>
James Buren <[email protected]>
Jan Macku <[email protected]>
Joey Boggs <[email protected]>
José María Fernández <[email protected]>
Julian Wolf <[email protected]>
Expand Down Expand Up @@ -226,7 +227,9 @@ Conrad Hoffmann <[email protected]>
Daan De Meyer <[email protected]>
Dan Fuhry <[email protected]>
Daniel McIlvaney <[email protected]>
Daniel P. Berrangé <[email protected]>
Dave Jones <[email protected]>
David Cassany <[email protected]>
David Hildenbrand <[email protected]>
David Michael <[email protected]>
Denis Volkov <[email protected]>
Expand Down Expand Up @@ -365,6 +368,7 @@ foopub <[email protected]>
gaoyi <[email protected]>
gombi <gombi@>
honza801 <[email protected]>
innovara <[email protected]>
jbash aka John Bashinski <[email protected]>
jloeser <[email protected]>
joamonwx <unknown>
Expand Down
217 changes: 217 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,222 @@
[Rendered view](https://github.com/dracutdevs/dracut/blob/master/NEWS.md)

dracut-050
==========

#### Features

* **systemd:** install systemd-executor ([bee1c482](https://github.com/dracutdevs/dracut/commit/bee1c4824a8cd47ce6c01892a548bdc07b1fa678))

#### Bug Fixes

* **dracut-initramfs-restore.sh:** do not set selinux labels if disabled ([4d594210](https://github.com/dracutdevs/dracut/commit/4d594210d6ef4f04a9dbadacea73e9461ded352d))
* **install.d:** do not create initramfs if the supplied image is UKI ([b2af8c8b](https://github.com/dracutdevs/dracut/commit/b2af8c8bcfc72802e02e2c0adc2eed9279101624))
* **overlayfs:** split overlayfs mount in two steps ([bddffeda](https://github.com/dracutdevs/dracut/commit/bddffedae038ceca263a904e40513a6e92f1b558))
* **pkcs11:** delete trailing dot on libcryptsetup-token-systemd-pkcs11.so ([1c762c0d](https://github.com/dracutdevs/dracut/commit/1c762c0da6ed2bb6fa44d5e0968605cc4d45361c))
* **systemd-journald:** add systemd-sysusers dependency ([4971f443](https://github.com/dracutdevs/dracut/commit/4971f443726360216a4ef3ba8baea258a1cd0f3b))
* **systemd-repart:** correct undefined $libdir ([1586af09](https://github.com/dracutdevs/dracut/commit/1586af098fb17f7565d1699953e4e4b536304089))

#### Contributors

- Harald Hoyer <[email protected]>
- Antonio Alvarez Feijoo <[email protected]>
- Jóhann B. Guðmundsson <[email protected]>
- Laszlo Gombos <[email protected]>
- Kairui Song <[email protected]>
- Daniel Molkentin <[email protected]>
- Martin Wilck <[email protected]>
- Henrik Gombos <[email protected]>
- Lubomir Rintel <[email protected]>
- Lukas Nykryn <[email protected]>
- Beniamino Galvani <[email protected]>
- наб <[email protected]>
- Jonathan Lebon <[email protected]>
- David Tardon <[email protected]>
- Frantisek Sumsal <[email protected]>
- David Disseldorp <[email protected]>
- Pavel Valena <[email protected]>
- Benjamin Drung <[email protected]>
- Thomas Blume <[email protected]>
- Renaud Métrich <[email protected]>
- Zoltán Böszörményi <[email protected]>
- Marcos Mello <[email protected]>
- Shreenidhi Shedi <[email protected]>
- David Teigland <[email protected]>
- Dusty Mabe <[email protected]>
- Frederick Grose <[email protected]>
- Kairui Song <[email protected]>
- Adrien Thierry <[email protected]>
- Alexander Tsoy <[email protected]>
- Böszörményi Zoltán <[email protected]>
- Mikhail Novosyolov <[email protected]>
- Tao Liu <[email protected]>
- Tomasz Paweł Gajc <[email protected]>
- Hannes Reinecke <[email protected]>
- Jonas Witschel <[email protected]>
- Nathan Rini <[email protected]>
- Đoàn Trần Công Danh <[email protected]>
- Jan Macku <[email protected]>
- Nicolas Chauvet <[email protected]>
- q66 <[email protected]>
- Andrew Ammerlaan <[email protected]>
- Colin Walters <[email protected]>
- Masahiro Matsuya <[email protected]>
- Mike Gilbert <[email protected]>
- Norbert Lange <[email protected]>
- Peter Robinson <[email protected]>
- Takashi Iwai <[email protected]>
- Zbigniew Jędrzejewski-Szmek <[email protected]>
- Zoltán Böszörményi <[email protected]>
- Brian C. Lane <[email protected]>
- Doan Tran Cong Danh <[email protected]>
- Gaël PORTAY <[email protected]>
- Jiri Konecny <[email protected]>
- Matt Coleman <[email protected]>
- Max Resch <[email protected]>
- Stefan Berger <[email protected]>
- Topi Miettinen <[email protected]>
- dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- keentux <[email protected]>
- Alberto Planas <[email protected]>
- Alexander Wenzel <[email protected]>
- Alexey Shabalin <[email protected]>
- Andre Russ <[email protected]>
- Andreas Schwab <[email protected]>
- Coiby Xu <[email protected]>
- Cornelius Hoffmann <[email protected]>
- Daniel Cordero <[email protected]>
- German Maglione <[email protected]>
- Hari Bathini <[email protected]>
- Javier Martinez Canillas <[email protected]>
- José María Fernández <[email protected]>
- Lee Duncan <[email protected]>
- LinkTed <[email protected]>
- Luiz Angelo Daros de Luca <[email protected]>
- Mariusz Tkaczyk <[email protected]>
- Michal Koutný <[email protected]>
- Nicolas Porcel <[email protected]>
- Patrick Talbert <[email protected]>
- Pedro Monreal <[email protected]>
- Petr Pavlu <[email protected]>
- Pingfan Liu <[email protected]>
- Tianhao Chai <[email protected]>
- Tony Asleson <[email protected]>
- nkraetzschmar <[email protected]>
- Érico Rolim <[email protected]>
- “Masahiro <[email protected]>
- 0x5c <[email protected]>
- A. Wilcox <[email protected]>
- Adam Alves <[email protected]>
- Adam Williamson <[email protected]>
- Alexander Miroshnichenko <[email protected]>
- Alexander Sosedkin <[email protected]>
- Alexey Kodanev <[email protected]>
- Andrew Halaney <[email protected]>
- Andrew J. Hesford <[email protected]>
- Andrey Sokolov <[email protected]>
- Anjali Kulkarni <[email protected]>
- Antz <[email protected]>
- Arnaud Rebillout <[email protected]>
- Attila Bruncsak <[email protected]>
- Ben Howard <[email protected]>
- Benjamin Gilbert <[email protected]>
- Benjamin Marzinski <[email protected]>
- Brandon Sloane <[email protected]>
- Bruno E. O. Meneguele <[email protected]>
- Charles Rose <[email protected]>
- Cole Robinson <[email protected]>
- Conrad Hoffmann <[email protected]>
- Daan De Meyer <[email protected]>
- Dan Horák <[email protected]>
- Daniel McIlvaney <[email protected]>
- Daniel P. Berrangé <[email protected]>
- David Cassany <[email protected]>
- David Hildenbrand <[email protected]>
- Denis Volkov <[email protected]>
- Derek Hageman <[email protected]>
- Dirk Müller <[email protected]>
- Dmitry Klochkov <[email protected]>
- Donovan Tremura <[email protected]>
- Emanuele Giuseppe Esposito <[email protected]>
- Enzo Matsumiya <[email protected]>
- Eugene S. Sobolev <[email protected]>
- Evgeni Golov <[email protected]>
- Fabian Vogt <[email protected]>
- Frank Deng <[email protected]>
- Frederick Grose <[email protected]>
- Glenn Morris <[email protected]>
- GuoChuang <[email protected]>
- Hans de Goede <[email protected]>
- Hongxu Jia <[email protected]>
- Jacob Wen <[email protected]>
- James Morris <[email protected]>
- Jaroslav Jindrak <[email protected]>
- Jens Heise <[email protected]>
- Jeremy Linton <[email protected]>
- John Meneghini <[email protected]>
- Jonas Jelten <[email protected]>
- Jonas Witschel <[email protected]>
- Kenneth D'souza <[email protected]>
- Khem Raj <[email protected]>
- Lars Wendler <[email protected]>
- Laura Hild <[email protected]>
- Lennart Poettering <[email protected]>
- Lev Veyde <[email protected]>
- Lianbo Jiang <[email protected]>
- Luca BRUNO <[email protected]>
- Lucas C. Villa Real <[email protected]>
- Marek Marczykowski-Górecki <[email protected]>
- Marko Myllynen <[email protected]>
- Matthew Thode <[email protected]>
- Matthias Berndt <[email protected]>
- Michal Hecko <[email protected]>
- Michał Zegan <[email protected]>
- Morten Linderud <[email protected]>
- Neal Gompa <[email protected]>
- Nicolas Saenz Julienne <[email protected]>
- Ondrej Dubaj <[email protected]>
- Ondrej Mosnacek <[email protected]>
- Paul Robins <[email protected]>
- Peter Georg <[email protected]>
- Peter Levine <[email protected]>
- Petr Tesarik <[email protected]>
- Petr Vorel <[email protected]>
- Radek Vykydal <[email protected]>
- Rumbaut Thomas <[email protected]>
- Sam James <[email protected]>
- Savyasachee Jha <[email protected]>
- Scott Moser <[email protected]>
- Sebastian Mitterle <[email protected]>
- Sergei Iudin <[email protected]>
- Sergio E. Nemirowski <[email protected]>
- Thierry Vignaud <[email protected]>
- Thomas Abraham <[email protected]>
- Thomas Haller <[email protected]>
- Valentin Lefebvre <[email protected]>
- Vitaly Kuznetsov <[email protected]>
- Vladius25 <[email protected]>
- Wenchao Hao <[email protected]>
- Yang Liu <[email protected]>
- foopub <[email protected]>
- gaoyi <[email protected]>
- gombi <gombi@>
- innovara <[email protected]>
- jbash aka John Bashinski <[email protected]>
- joamonwx <unknown>
- joshuacov1 <[email protected]>
- lapseofreason <[email protected]>
- leo-lb <[email protected]>
- lilinjie <[email protected]>
- logan <[email protected]>
- masem <[email protected]>
- mulhern <[email protected]>
- mwberry <[email protected]>
- nabijaczleweli <[email protected]>
- realtime-neil <[email protected]>
- runsisi <[email protected]>
- tupper <[email protected]>
- Дамјан Георгиевски <[email protected]>

dracut-060
==========

Expand Down
2 changes: 1 addition & 1 deletion dracut-version.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/bin/sh
# shellcheck disable=SC2034
DRACUT_VERSION=060
DRACUT_VERSION=050