Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: release #2417

Merged
merged 1 commit into from
Jul 13, 2023
Merged

ci: release #2417

merged 1 commit into from
Jul 13, 2023

Conversation

Henrik66
Copy link
Contributor

@Henrik66 Henrik66 commented Jun 28, 2023

This pull request allows making a release using a Github Action.

I tested it on my personal fork.

This is how a release page turned out - https://github.com/Henrik66/dracut/releases/tag/060

This is the commit the release process generated - Henrik66@d340cea

Fixes #2416

Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated commit and Github release page looks good.

@LaszloGombos LaszloGombos added this to the dracut-060 milestone Jul 4, 2023
Copy link
Member

@aafeijoo-suse aafeijoo-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss the contributors list in your test release: https://github.com/Henrik66/dracut/releases/tag/060 (see https://github.com/dracutdevs/dracut/releases/tag/057). Is it expected?

@Henrik66
Copy link
Contributor Author

Henrik66 commented Jul 8, 2023

I miss the contributors list in your test release: https://github.com/Henrik66/dracut/releases/tag/060 (see https://github.com/dracutdevs/dracut/releases/tag/057). Is it expected?

Thanks you @aafeijoo-suse . No this is not expected. I missed it and now corrected it.

@aafeijoo-suse
Copy link
Member

Thanks! Can you confirm that the "Dracut Release Bot" is not creating a duplicate release entry in NEWS.md?

@Henrik66
Copy link
Contributor Author

Thanks! Can you confirm that the "Dracut Release Bot" is not creating a duplicate release entry in NEWS.md?

Sorry for the confusion. I think the 2 commits were because of my debugging.

I reapplied the PR and re-run the release generation, which lead to a clean commit history.

Henrik66@472c839

Copy link
Member

@aafeijoo-suse aafeijoo-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion. I think the 2 commits were because of my debugging.

I reapplied the PR and re-run the release generation, which lead to a clean commit history.

Henrik66@472c839

No problem, thanks!

@LaszloGombos LaszloGombos merged commit 81d78c4 into dracutdevs:master Jul 13, 2023
65 of 78 checks passed
@Henrik66 Henrik66 deleted the rel branch July 13, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github Issues related to .github
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Github Actions to make a release
3 participants