Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump luizm/action-sh-checker from 0.6.0 to 0.8.0 #3

Merged
merged 1 commit into from
Apr 2, 2024
Merged

chore(deps): bump luizm/action-sh-checker from 0.6.0 to 0.8.0 #3

merged 1 commit into from
Apr 2, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 30, 2024

Bumps luizm/action-sh-checker from 0.6.0 to 0.8.0.

Release notes

Sourced from luizm/action-sh-checker's releases.

v0.8.0

Bump versions

v0.7.0

No release notes provided.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 30, 2024
@Conan-Kudo Conan-Kudo force-pushed the dependabot/github_actions/luizm/action-sh-checker-0.8.0 branch from df868dd to 0195cec Compare March 30, 2024 01:18
@LaszloGombos LaszloGombos force-pushed the dependabot/github_actions/luizm/action-sh-checker-0.8.0 branch from 0195cec to 99771b8 Compare March 30, 2024 18:20
@github-actions github-actions bot added the github Issues related to .github label Mar 30, 2024
@github-actions GitHub Actions
Copy link

sh-checker report

To get the full details, please check in the job output.

shellcheck errors 

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In dracut-catimages.sh line 20:
    echo "Warning: $*" >&2
    ^--------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In dracut-init.sh line 38:
    dracutbasedir="$(readlink -f $dracutbasedir)"
                                 ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    dracutbasedir="$(readlink -f "$dracutbasedir")"


In dracut-logger.sh line 182:
        dtrace() { :; }
                   ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In dracut-logger.sh line 187:
        ddebug() { :; }
                   ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In dracut-logger.sh line 192:
        dinfo() { :; }
                  ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In dracut-logger.sh line 197:
        dwarn() { :; }
                  ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In dracut-logger.sh line 199:
        dwarning() { :; }
                     ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In dracut-logger.sh line 209:
        dfatal() { :; }
                   ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In dracut-logger.sh line 330:
            printf -- "<%s>%s\n" "$(($(_dlvl2syslvl "$lvl") & 7))" "$msg" >&$_dlogfd
                                                                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
            printf -- "<%s>%s\n" "$(($(_dlvl2syslvl "$lvl") & 7))" "$msg" >&"$_dlogfd"


In dracut.sh line 320:
    local rematch='^[^=]*=(.*)$'
    ^--------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In dracut.sh line 321:
    if [[ $2 =~ $rematch ]]; then
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
       ^------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In dracut.sh line 322:
        read -r "$1" <<< "${BASH_REMATCH[1]}"
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In dracut.sh line 324:
        read -r "$1" <<< "$3"
        ^-------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In dracut.sh line 327:
        return 1
        ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In dracut.sh line 1380:
        && dracut_args[$i]="\"${dracut_args[$i]}\""
                       ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables.


In dracut.sh line 2108:
        if ! type -P $p > /dev/null; then
                     ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        if ! type -P "$p" > /dev/null; then


In dracut.sh line 2256:
        | xargs -r -0 $strip_cmd "${strip_args[@]}" 2> /dev/null
                      ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        | xargs -r -0 "$strip_cmd" "${strip_args[@]}" 2> /dev/null


In dracut.sh line 2263:
        done | xargs -r -0 $strip_cmd "${strip_args[@]}"
                           ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        done | xargs -r -0 "$strip_cmd" "${strip_args[@]}"


In lsinitrd.sh line 352:
    $SKIP "$@" | $ORIG_CAT
    ^--------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In lsinitrd.sh line 364:
        cat "$TMPFILE"
        ^------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/09dbus/module-setup.sh line 30:
    return 1
    ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/30convertfs/convertfs.sh line 76:
    local dev wanted_dev
    ^------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/30convertfs/convertfs.sh line 77:
    wanted_dev="$(readlink -e -q "$1")"
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                  ^-----------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/30convertfs/convertfs.sh line 78:
    while read -r dev _ || [ -n "$dev" ]; do
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
          ^------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                           ^-----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/30convertfs/convertfs.sh line 79:
        [ "$dev" = "$wanted_dev" ] && echo "$dev" && return 0
        ^-------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                      ^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                                     ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/30convertfs/convertfs.sh line 81:
    return 1
    ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/30convertfs/convertfs.sh line 86:
    echo "Something failed. Move back to the original state"
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/30convertfs/convertfs.sh line 87:
    for dir in "$ROOT/bin" "$ROOT/sbin" "$ROOT/lib" "$ROOT/lib64" \
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/30convertfs/convertfs.sh line 90:
        [[ -d "${dir}.usrmove-new" ]] && rm -fr -- "${dir}.usrmove-new"
        ^----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                         ^----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/30convertfs/convertfs.sh line 91:
        if [[ -d "${dir}.usrmove-old" ]]; then
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
           ^---------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/30convertfs/convertfs.sh line 92:
            mv "$dir" "${dir}.del~"
            ^---------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/30convertfs/convertfs.sh line 93:
            mv "${dir}.usrmove-old" "$dir"
            ^----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/30convertfs/convertfs.sh line 94:
            rm -fr -- "${dir}.del~"
            ^---------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/30convertfs/convertfs.sh line 117:
    cp -axT $CP_HARDLINK --backup --suffix=.usrmove~ "$ROOT/$dir" "$ROOT/usr/${dir}.usrmove-new"
            ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    cp -axT "$CP_HARDLINK" --backup --suffix=.usrmove~ "$ROOT/$dir" "$ROOT/usr/${dir}.usrmove-new"


In modules.d/35network-legacy/parse-bridge.sh line 48:
    } > /tmp/bridge.${bridgename}.info
                    ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    } > /tmp/bridge."${bridgename}".info


In modules.d/80lvmthinpool-monitor/start-thinpool-monitor.sh line 12:
    [ -n "$_lvm2_thin_device" ] && return $?
                                          ^-- SC2319 (warning): This $? refers to a condition, not a command. Assign to a variable to avoid it being overwritten.


In modules.d/80test-root/module-setup.sh line 20:
    inst_multiple -o ${_terminfodir}/l/linux
                     ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    inst_multiple -o "${_terminfodir}"/l/linux


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 160:
        if [ -f /run/initramfs/overlayfs$pathspec -a -w /run/initramfs/overlayfs$pathspec ]; then
                                        ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                                ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        if [ -f /run/initramfs/overlayfs"$pathspec" -a -w /run/initramfs/overlayfs"$pathspec" ]; then


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 161:
            OVERLAY_LOOPDEV=$(losetup -f --show ${readonly_overlay:+-r} /run/initramfs/overlayfs$pathspec)
                                                                                                ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
            OVERLAY_LOOPDEV=$(losetup -f --show ${readonly_overlay:+-r} /run/initramfs/overlayfs"$pathspec")


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 188:
        elif [ -d /run/initramfs/overlayfs$pathspec ] \
                                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        elif [ -d /run/initramfs/overlayfs"$pathspec" ] \


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 189:
            && [ -d /run/initramfs/overlayfs$pathspec/../ovlwork ]; then
                                            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
            && [ -d /run/initramfs/overlayfs"$pathspec"/../ovlwork ]; then


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 190:
            ln -s /run/initramfs/overlayfs$pathspec /run/overlayfs${readonly_overlay:+-r}
                                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
            ln -s /run/initramfs/overlayfs"$pathspec" /run/overlayfs${readonly_overlay:+-r}


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 191:
            ln -s /run/initramfs/overlayfs$pathspec/../ovlwork /run/ovlwork${readonly_overlay:+-r}
                                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
            ln -s /run/initramfs/overlayfs"$pathspec"/../ovlwork /run/ovlwork${readonly_overlay:+-r}


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 313:
if [ -e /run/initramfs/live/${live_dir}/${squash_image} ]; then
                            ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
if [ -e /run/initramfs/live/"${live_dir}"/"${squash_image}" ]; then


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 318:
        imgsize=$(($(stat -c %s -- $SQUASHED) / (1024 * 1024)))
                                   ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        imgsize=$(($(stat -c %s -- "$SQUASHED") / (1024 * 1024)))


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 322:
        dd if=$SQUASHED of=/run/initramfs/squashed.img bs=512 2> /dev/null
              ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        dd if="$SQUASHED" of=/run/initramfs/squashed.img bs=512 2> /dev/null


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 328:
    losetup -r "$SQUASHED_LOOPDEV" $SQUASHED
                                   ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    losetup -r "$SQUASHED_LOOPDEV" "$SQUASHED"


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 350:
    if [ -e /run/initramfs/live/${live_dir}/rootfs.img ]; then
                                ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    if [ -e /run/initramfs/live/"${live_dir}"/rootfs.img ]; then


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 352:
    elif [ -e /run/initramfs/live/${live_dir}/ext3fs.img ]; then
                                  ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    elif [ -e /run/initramfs/live/"${live_dir}"/ext3fs.img ]; then


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 358:
        dd if=$FSIMG of=/run/initramfs/rootfs.img bs=512 2> /dev/null
              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        dd if="$FSIMG" of=/run/initramfs/rootfs.img bs=512 2> /dev/null


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 370:
            cp -v $FSIMG /run/initramfs/fsimg/rootfs.img
                  ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
            cp -v "$FSIMG" /run/initramfs/fsimg/rootfs.img


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 372:
            unpack_archive $FSIMG /run/initramfs/fsimg/
                           ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
            unpack_archive "$FSIMG" /run/initramfs/fsimg/


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 391:
        BASE_LOOPDEV=$(losetup -f --show ${readonly_base:+-r} $FSIMG)
                                                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        BASE_LOOPDEV=$(losetup -f --show ${readonly_base:+-r} "$FSIMG")


In modules.d/90dmsquash-live/dmsquash-live-root.sh line 416:
        mount -r $FSIMG /run/rootfsbase
                 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        mount -r "$FSIMG" /run/rootfsbase


In modules.d/90dmsquash-live-autooverlay/create-overlay.sh line 103:
    mkdir -p ${baseDir}/${live_dir}/ovlwork
                        ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    mkdir -p ${baseDir}/"${live_dir}"/ovlwork


In modules.d/90kernel-modules/module-setup.sh line 10:
        for _mod in $(get_dev_module /dev/block/"$1"); do
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                      ^----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/90kernel-modules/module-setup.sh line 11:
            _hostonly_drvs["$_mod"]="$_mod"
            ^-----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/90kernel-modules/module-setup.sh line 14:
        for _mod in $(get_blockdev_drv_through_sys "/sys/dev/block/$1"); do
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                      ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/90kernel-modules/module-setup.sh line 15:
            _hostonly_drvs["$_mod"]="$_mod"
            ^-----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/90kernel-modules/module-setup.sh line 18:
        ((${#_hostonly_drvs[@]} > 0)) && return 0
        ^----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                         ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/90kernel-modules/module-setup.sh line 19:
        return 1
        ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/90multipath/module-setup.sh line 73:
        if is_mpath "$1"; then
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
           ^-----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/90multipath/module-setup.sh line 74:
            local _dev
            ^--------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/90multipath/module-setup.sh line 76:
            _dev=$(majmin_to_mpath_dev "$1")
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                   ^----------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/90multipath/module-setup.sh line 77:
            [ -z "$_dev" ] && return
            ^-------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                              ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/90multipath/module-setup.sh line 78:
            _allow["$_dev"]="$_dev"
            ^---------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/91zipl/module-setup.sh line 39:
            instmods ${ID_FS_TYPE}
                     ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
            instmods "${ID_FS_TYPE}"


In modules.d/91zipl/parse-zipl.sh line 45:
                ${zipl_env} "${zipl_val}" "${zipl_arg}"
                ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
                "${zipl_env}" "${zipl_val}" "${zipl_arg}"


In modules.d/95dasd_rules/module-setup.sh line 6:
        local _dev=$1
        ^-----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95dasd_rules/module-setup.sh line 7:
        local _devpath
        ^------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95dasd_rules/module-setup.sh line 8:
        _devpath=$(
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95dasd_rules/module-setup.sh line 9:
            cd -P /sys/dev/block/"$_dev" || exit
            ^---------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                            ^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95dasd_rules/module-setup.sh line 10:
            echo "$PWD"
            ^---------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95dasd_rules/module-setup.sh line 13:
        [ "${_devpath#*/dasd}" == "$_devpath" ] && return 1
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                                   ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95dasd_rules/module-setup.sh line 14:
        _ccw="${_devpath%%/block/*}"
        ^--------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95dasd_rules/module-setup.sh line 15:
        echo "rd.dasd=${_ccw##*/}"
        ^------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95dasd_rules/module-setup.sh line 16:
        return 0
        ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95fcoe/module-setup.sh line 6:
        block_is_fcoe "$1" || return 1
        ^-----------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                              ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95fcoe-uefi/module-setup.sh line 6:
        block_is_fcoe "$1" || return 1
        ^-----------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                              ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95iscsi/iscsiroot.sh line 232:
    [ -z "$targets" ] && warn "Target discovery to $iscsi_target_ip:${iscsi_target_port:+$iscsi_target_port} failed with status $?" && return 1
                                                                                                                                ^-- SC2319 (warning): This $? refers to a condition, not a command. Assign to a variable to avoid it being overwritten.


In modules.d/95iscsi/module-setup.sh line 138:
        local _dev=$1
        ^-----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95iscsi/module-setup.sh line 139:
        local iscsi_dev
        ^-------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95iscsi/module-setup.sh line 141:
        [[ -L "/sys/dev/block/$_dev" ]] || return
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                           ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95iscsi/module-setup.sh line 142:
        iscsi_dev=$(
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95iscsi/module-setup.sh line 143:
            cd -P /sys/dev/block/"$_dev" || exit
            ^---------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                            ^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95iscsi/module-setup.sh line 144:
            echo "$PWD"
            ^---------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95iscsi/module-setup.sh line 146:
        install_iscsiroot "$iscsi_dev"
        ^----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/fc_transport_scan_lun.sh line 26:
echo "$CHANNEL" "$TARGET" $LUN > /sys/class/scsi_host/host"$HOST"/scan
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
echo "$CHANNEL" "$TARGET" "$LUN" > /sys/class/scsi_host/host"$HOST"/scan


In modules.d/95lunmask/module-setup.sh line 8:
        local _dev=$1
        ^-----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 9:
        local _devpath _sdev _lun _rport _end_device _classdev _wwpn _sas_address
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 10:
        _devpath=$(
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 11:
            cd -P /sys/dev/block/"$_dev" || exit
            ^---------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                            ^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 12:
            echo "$PWD"
            ^---------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 15:
        [ "${_devpath#*/sd}" == "$_devpath" ] && return 1
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                                 ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 16:
        _sdev="${_devpath%%/block/*}"
        ^---------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 17:
        _lun="${_sdev##*:}"
        ^-----------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 19:
        _rport="${_devpath##*/rport-}"
        ^----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 20:
        if [ "$_rport" != "$_devpath" ]; then
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
           ^--------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 21:
            _rport="${_rport%%/*}"
            ^--------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 22:
            _classdev="/sys/class/fc_remote_ports/rport-${_rport}"
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 23:
            [ -d "$_classdev" ] || return 1
            ^------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                   ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 24:
            read -r _wwpn < "${_classdev}"/port_name
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 25:
            echo "rd.lunmask=fc,${_wwpn},${_lun}"
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 26:
            return 0
            ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 29:
        _end_device="${_devpath##*/end_device-}"
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 30:
        if [ "$_end_device" != "$_devpath" ]; then
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
           ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 31:
            _end_device="${_end_device%%/*}"
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 32:
            _classdev="/sys/class/sas_device/end_device-${_end_device}"
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 33:
            [ -e "$_classdev" ] || return 1
            ^------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                   ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 34:
            read -r _sas_address < "${_classdev}"/sas_address
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 35:
            echo "rd.lunmask=sas,${_sas_address},${_lun}"
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 36:
            return 0
            ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/module-setup.sh line 38:
        return 1
        ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95lunmask/sas_transport_scan_lun.sh line 26:
echo 0 "$TARGET" $LUN > /sys/class/scsi_host/host"$HOST"/scan
                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
echo 0 "$TARGET" "$LUN" > /sys/class/scsi_host/host"$HOST"/scan


In modules.d/95nfs/nfsroot-cleanup.sh line 19:
    [ -d "$NEWROOT"/$rpcpipefspath ] \
                    ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    [ -d "$NEWROOT"/"$rpcpipefspath" ] \


In modules.d/95nfs/nfsroot-cleanup.sh line 20:
        || mkdir -m 0755 -p "$NEWROOT"/$rpcpipefspath 2> /dev/null
                                       ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        || mkdir -m 0755 -p "$NEWROOT"/"$rpcpipefspath" 2> /dev/null


In modules.d/95nfs/nfsroot-cleanup.sh line 22:
    if [ -d "$NEWROOT"/$rpcpipefspath ]; then
                       ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    if [ -d "$NEWROOT"/"$rpcpipefspath" ]; then


In modules.d/95nfs/nfsroot-cleanup.sh line 24:
        mount --bind /var/lib/nfs/rpc_pipefs "$NEWROOT"/$rpcpipefspath
                                                        ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        mount --bind /var/lib/nfs/rpc_pipefs "$NEWROOT"/"$rpcpipefspath"


In modules.d/95nvmf/module-setup.sh line 10:
        local _dev=$1
        ^-----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 11:
        local trtype
        ^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 13:
        [[ -L "/sys/dev/block/$_dev" ]] || return 0
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                           ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 14:
        cd -P "/sys/dev/block/$_dev" || return 0
        ^---------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                        ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 15:
        if [ -f partition ]; then
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
           ^--------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 16:
            cd ..
            ^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 18:
        for d in device/nvme*; do
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 19:
            [ -L "$d" ] || continue
            ^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                           ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 20:
            if readlink "$d" | grep -q nvme-fabrics; then
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
               ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 21:
                read -r trtype < "$d"/transport
                ^-----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 22:
                break
                ^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 25:
        [[ $trtype == "fc" ]] || [[ $trtype == "tcp" ]] || [[ $trtype == "rdma" ]]
        ^--------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                 ^---------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                                           ^---------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 72:
        local _dev=$1
        ^-----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 73:
        local trtype
        ^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 74:
        local traddr
        ^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 75:
        local host_traddr
        ^---------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 76:
        local trsvcid
        ^-----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 77:
        local _address
        ^------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 78:
        local -a _address_parts
        ^---------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 80:
        [[ -L "/sys/dev/block/$_dev" ]] || return 0
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                           ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 81:
        cd -P "/sys/dev/block/$_dev" || return 0
        ^---------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                        ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 82:
        if [ -f partition ]; then
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
           ^--------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 83:
            cd ..
            ^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 85:
        for d in device/nvme*; do
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 86:
            [ -L "$d" ] || continue
            ^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                           ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 87:
            if readlink "$d" | grep -q nvme-fabrics; then
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
               ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 88:
                read -r trtype < "$d"/transport
                ^-----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 89:
                break
                ^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 93:
        [ -z "$trtype" ] && return 0
        ^---------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                            ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 94:
        nvme list-subsys "${PWD##*/}" | while read -r _ _ trtype _address _; do
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                              ^---------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 95:
            [[ -z $trtype || $trtype != "${trtype#NQN}" ]] && continue
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                                              ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 96:
            unset traddr
            ^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 97:
            unset host_traddr
            ^---------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 98:
            unset trsvcid
            ^-----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 99:
            mapfile -t -d ',' _address_parts < <(printf "%s" "$_address")
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                                 ^---------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 100:
            for i in "${_address_parts[@]}"; do
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 101:
                [[ $i =~ ^traddr= ]] && traddr="${i#traddr=}"
                ^-------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                        ^-------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 102:
                [[ $i =~ ^host_traddr= ]] && host_traddr="${i#host_traddr=}"
                ^------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                             ^-----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 103:
                [[ $i =~ ^trsvcid= ]] && trsvcid="${i#trsvcid=}"
                ^--------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                         ^---------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 105:
            [[ -z $traddr && -z $host_traddr && -z $trsvcid ]] && continue
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                                                  ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95nvmf/module-setup.sh line 106:
            echo -n " rd.nvmf.discover=$trtype,$traddr,$host_traddr,$trsvcid"
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 6:
        local _dev=$1
        ^-----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 7:
        local _devpath
        ^------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 8:
        _devpath=$(
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 9:
            cd -P /sys/dev/block/"$_dev" || exit
            ^---------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                            ^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 10:
            echo "$PWD"
            ^---------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 12:
        local _sdev _scsiid _hostno _lun _wwpn _ccw _port_type
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 13:
        local _allow_lun_scan _is_npiv
        ^----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 15:
        read -r _allow_lun_scan < /sys/module/zfcp/parameters/allow_lun_scan
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 16:
        [ "${_devpath#*/sd}" == "$_devpath" ] && return 1
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                                 ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 17:
        _sdev="${_devpath%%/block/*}"
        ^---------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 18:
        [ -e "${_sdev}"/fcp_lun ] || return 1
        ^------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                     ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 19:
        _scsiid="${_sdev##*/}"
        ^--------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 20:
        _hostno="${_scsiid%%:*}"
        ^----------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 21:
        [ -d /sys/class/fc_host/host"${_hostno}" ] || return 1
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                                      ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 22:
        read -r _port_type < /sys/class/fc_host/host"${_hostno}"/port_type
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 23:
        case "$_port_type" in
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 25:
                _is_npiv=1
                ^--------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 28:
        read -r _ccw < "${_sdev}"/hba_id
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 29:
        if [ "$_is_npiv" ] && [ "$_allow_lun_scan" = "Y" ]; then
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
           ^--------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                              ^--------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 30:
            echo "rd.zfcp=${_ccw}"
            ^--------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 32:
            read -r _lun < "${_sdev}"/fcp_lun
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 33:
            read -r _wwpn < "${_sdev}"/wwpn
            ^-----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 34:
            echo "rd.zfcp=${_ccw},${_wwpn},${_lun}"
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/95zfcp_rules/module-setup.sh line 36:
        return 0
        ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In modules.d/98syslog/rsyslogd-start.sh line 44:
        rsyslog_config "$server" "$template" "$filters" > $conf
                                                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        rsyslog_config "$server" "$template" "$filters" > "$conf"


In modules.d/99base/dracut-lib.sh line 269:
            && [ $_b -ge "$_min" ] && [ $_b -le "$_max" ] && echo $_b && return
                 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
            && [ "$_b" -ge "$_min" ] && [ "$_b" -le "$_max" ] && echo "$_b" && return


In modules.d/99base/dracut-lib.sh line 940:
            while [ -f /sys/class/tty/$_ctty/active ]; do
                                      ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
            while [ -f /sys/class/tty/"$_ctty"/active ]; do


In modules.d/99base/dracut-lib.sh line 941:
                read -r _ctty < /sys/class/tty/$_ctty/active
                                               ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
                read -r _ctty < /sys/class/tty/"$_ctty"/active


In modules.d/99base/dracut-lib.sh line 948:
        setsid $CTTY /bin/sh -i -l 0<> $_ctty 1<> $_ctty 2<> $_ctty
               ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                       ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                  ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                             ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        setsid "$CTTY" /bin/sh -i -l 0<> "$_ctty" 1<> "$_ctty" 2<> "$_ctty"


In modules.d/99base/dracut-lib.sh line 1005:
        eval val=\$$var
                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        eval val=\$"$var"


In modules.d/99base/dracut-lib.sh line 1006:
        unset $var
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        unset "$var"


In test/TEST-01-BASIC/test-init.sh line 20:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-02-SYSTEMD/test-init.sh line 20:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-03-USR-MOUNT/test-init.sh line 20:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-04-FULL-SYSTEMD/test-init.sh line 37:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-10-RAID/test-init.sh line 20:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-10-RAID/test.sh line 44:
        inst_multiple -o ${_terminfodir}/l/linux
                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        inst_multiple -o "${_terminfodir}"/l/linux


In test/TEST-11-LVM/test-init.sh line 20:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-11-LVM/test.sh line 45:
        inst_multiple -o ${_terminfodir}/l/linux
                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        inst_multiple -o "${_terminfodir}"/l/linux


In test/TEST-12-RAID-DEG/test-init.sh line 20:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-12-RAID-DEG/test.sh line 76:
        inst_multiple -o ${_terminfodir}/l/linux
                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        inst_multiple -o "${_terminfodir}"/l/linux


In test/TEST-13-ENC-RAID-LVM/test-init.sh line 20:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-13-ENC-RAID-LVM/test.sh line 72:
        inst_multiple -o ${_terminfodir}/l/linux
                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        inst_multiple -o "${_terminfodir}"/l/linux


In test/TEST-14-IMSM/test-init.sh line 20:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-14-IMSM/test.sh line 70:
        inst_multiple -o ${_terminfodir}/l/linux
                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        inst_multiple -o "${_terminfodir}"/l/linux


In test/TEST-15-BTRFSRAID/test-init.sh line 20:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-15-BTRFSRAID/test.sh line 48:
        inst_multiple -o ${_terminfodir}/l/linux
                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        inst_multiple -o "${_terminfodir}"/l/linux


In test/TEST-16-DMSQUASH/test-init.sh line 26:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-17-LVM-THIN/test-init.sh line 20:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-17-LVM-THIN/test.sh line 43:
        inst_multiple -o ${_terminfodir}/l/linux
                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        inst_multiple -o "${_terminfodir}"/l/linux


In test/TEST-20-NFS/client-init.sh line 16:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-30-ISCSI/client-init.sh line 20:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-35-ISCSI-MULTI/client-init.sh line 20:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-35-ISCSI-MULTI/test.sh line 163:
        inst_multiple -o ${_terminfodir}/l/linux
                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        inst_multiple -o "${_terminfodir}"/l/linux


In test/TEST-35-ISCSI-MULTI/test.sh line 236:
        inst_multiple -o ${_terminfodir}/l/linux
                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        inst_multiple -o "${_terminfodir}"/l/linux


In test/TEST-40-NBD/client-init.sh line 23:
    setsid $CTTY sh -i
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    setsid "$CTTY" sh -i


In test/TEST-40-NBD/test.sh line 209:
        inst_multiple -o ${_terminfodir}/l/linux
                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        inst_multiple -o "${_terminfodir}"/l/linux


In test/TEST-40-NBD/test.sh line 288:
        inst_multiple -o ${_terminfodir}/l/linux
                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        inst_multiple -o "${_terminfodir}"/l/linux


In test/TEST-40-NBD/test.sh line 380:
        inst_multiple -o ${_terminfodir}/l/linux
                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        inst_multiple -o "${_terminfodir}"/l/linux


In test/TEST-98-GETARG/test.sh line 95:
            :
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In test/TEST-98-GETARG/test.sh line 99:
            :
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In test/TEST-98-GETARG/test.sh line 103:
            echo "rdbreak=cmdline rd.lvm rd.auto=0 rd.auto rd.retry=10"
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In test/TEST-98-GETARG/test.sh line 112:
            echo "rd.break=cmdlined rd.lvm=0 rd.auto rd.auto=1 rd.auto=0"
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In test/TEST-98-GETARG/test.sh line 119:
            echo "ip=a ip=b ip=dhcp6"
            ^-----------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In test/TEST-98-GETARG/test.sh line 130:
            echo "bridge bridge=val"
            ^----------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In test/TEST-98-GETARG/test.sh line 140:
            echo "rd.break rd.md.uuid=bf96e457:230c9ad4:1f3e59d6:745cf942 rd.md.uuid=bf96e457:230c9ad4:1f3e59d6:745cf943 rd.shell"
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

For more information:
  https://www.shellcheck.net/wiki/SC2319 -- This $? refers to a condition, no...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
shfmt errors 
'shfmt -s' found no issues.

@LaszloGombos
Copy link
Collaborator

This is a major effort and not the right time.
Related

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 30, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/github_actions/luizm/action-sh-checker-0.8.0 branch March 30, 2024 22:28
@LaszloGombos LaszloGombos restored the dependabot/github_actions/luizm/action-sh-checker-0.8.0 branch April 2, 2024 19:03
@LaszloGombos LaszloGombos reopened this Apr 2, 2024
@dependabot @LaszloGombos
chore(deps): bump luizm/action-sh-checker from 0.6.0 to 0.8.0
59a2a10 
Bumps [luizm/action-sh-checker](https://github.com/luizm/action-sh-checker) from 0.6.0 to 0.8.0.
- [Release notes](https://github.com/luizm/action-sh-checker/releases)
- [Commits](luizm/action-sh-checker@v0.6.0...v0.8.0)

---
updated-dependencies:
- dependency-name: luizm/action-sh-checker
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@LaszloGombos LaszloGombos force-pushed the dependabot/github_actions/luizm/action-sh-checker-0.8.0 branch from 99771b8 to 59a2a10 Compare April 2, 2024 19:05
LaszloGombos
LaszloGombos approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the project gained a better solution for #75 we can move on for upgrading shfmt

@LaszloGombos LaszloGombos merged commit 0a2525c into main Apr 2, 2024
13 of 103 checks passed
@dependabot dependabot bot deleted the dependabot/github_actions/luizm/action-sh-checker-0.8.0 branch April 2, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaszloGombos LaszloGombos LaszloGombos approved these changes

@Conan-Kudo Conan-Kudo Awaiting requested review from Conan-Kudo

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file github Issues related to .github
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LaszloGombos