Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Diffs hard to read with cursorline over text #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sprloth
Copy link

@sprloth sprloth commented May 14, 2022

Fix the problem Diffs hard to read with cursorline over text, #130

Fix the problem Diffs hard to read with cursorline over text, dracula#130
@benknoble
Copy link
Member

Looks like a reasonable change, but it will be a while before I can test it. Do you have a screenshot or two?

@sprloth
Copy link
Author

sprloth commented May 23, 2022

before
屏幕截图 2022-05-23 204305

after
屏幕截图 2022-05-23 204554

@benknoble
Copy link
Member

Hi, sorry about the delay; just a heads up that this is still in my backlog of things to do and I haven't forgotten about it.

If @dsifford has time to test and approves than I trust their decision, too.

@benknoble
Copy link
Member

Sorry again for the delay: I just took at the issue you describe, and it doesn't happen when you don't use cursorline—how does your fix impact nocursorline? Can you share a screenshot (before/after would be great for posterity) without cursorline so we can verify that it doesn't break anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants