send out of dialog BYE to node instead of rejecting #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain more about the PR ? |
|
I believe @tsearle had some scenario that involved him needing this change. However, I have not merged yet because I am not sure I agree with it....if we get a BYE that is not related to an established dialog, I still feel like the proper response is for the server to generate a 481 Transaction does not exist. Leaving this open for further discussion at the moment.. |
|
The goal was to not use the dialog layer in drachtio, instead manage dialog state in the node app, that way it could be persisted & restored on restart for high availability reasons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.