Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade (flask-)sqlalchemy #2162

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

goerch
Copy link

@goerch goerch commented Nov 16, 2023

I'm currently interested in getting the tests to run. It would be great to get some guidance if and how we should handle and test compatibility of the PR w.r.t. older versions of SQLAlchemy?

@goerch goerch changed the title Upgrade (flask-)sqlalchemy chore: upgrade (flask-)sqlalchemy Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (59db85d) 79.31% compared to head (67729a0) 79.28%.

Files Patch % Lines
flask_appbuilder/models/sqla/__init__.py 57.14% 6 Missing ⚠️
flask_appbuilder/cli.py 0.00% 1 Missing ⚠️
flask_appbuilder/models/sqla/interface.py 85.71% 1 Missing ⚠️
flask_appbuilder/security/sqla/manager.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2162      +/-   ##
==========================================
- Coverage   79.31%   79.28%   -0.04%     
==========================================
  Files          72       72              
  Lines        8974     8953      -21     
==========================================
- Hits         7118     7098      -20     
+ Misses       1856     1855       -1     
Flag Coverage Δ
python 79.28% <76.92%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacqed
Copy link

zacqed commented Nov 24, 2023

@dpgaspar would you be able to review this. many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants