This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Add a multi_value_processor
plugin to the tide_data_pipeline
module to handle multiple values.
#85
Merged
vincent-gao
merged 4 commits into
develop
from
feature/add-mutiple_values-plugin-for-pipeline
Aug 2, 2024
Merged
Add a multi_value_processor
plugin to the tide_data_pipeline
module to handle multiple values.
#85
vincent-gao
merged 4 commits into
develop
from
feature/add-mutiple_values-plugin-for-pipeline
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-gao
force-pushed
the
feature/add-mutiple_values-plugin-for-pipeline
branch
4 times, most recently
from
July 19, 2024 12:16
a8aba94
to
79ec01d
Compare
vincent-gao
changed the title
adds mutiple_value_processor plugin for datapipe
Add a Jul 19, 2024
multiple_value_processor
plugin to the tide_data_pipeline module to handle multiple values.
vincent-gao
changed the title
Add a
Add a Jul 19, 2024
multiple_value_processor
plugin to the tide_data_pipeline module to handle multiple values.multiple_value_processor
plugin to the tide_data_pipeline
module to handle multiple values.
vincent-gao
force-pushed
the
feature/add-mutiple_values-plugin-for-pipeline
branch
from
July 19, 2024 12:26
79ec01d
to
de3a112
Compare
vincent-gao
force-pushed
the
feature/add-mutiple_values-plugin-for-pipeline
branch
from
July 19, 2024 13:10
de3a112
to
2886a8c
Compare
vincent-gao
changed the title
Add a
Add a Jul 21, 2024
multiple_value_processor
plugin to the tide_data_pipeline
module to handle multiple values.multi_value_processor
plugin to the tide_data_pipeline
module to handle multiple values.
vincent-gao
requested review from
anthony-malkoun,
MdNadimHossain and
yeniatencio
July 21, 2024 23:26
vincent-gao
force-pushed
the
feature/add-mutiple_values-plugin-for-pipeline
branch
14 times, most recently
from
July 22, 2024 06:52
76323cf
to
446a32f
Compare
vincent-gao
force-pushed
the
feature/add-mutiple_values-plugin-for-pipeline
branch
2 times, most recently
from
July 22, 2024 09:28
40d96dc
to
9cebc0b
Compare
vincent-gao
force-pushed
the
feature/add-mutiple_values-plugin-for-pipeline
branch
from
July 22, 2024 22:57
9468c3a
to
5dfaf70
Compare
All unit/kernal tests have passed. The failure is only because our DevOps team is debugging why |
anthony-malkoun
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've discussed the approach so happy to approve this. Good find with the delete issues.
@vincent-gao are we doing anything about the builds failing and removing the circle jobs? |
Yes, currently, we are doing a mono-repo, should we remove the |
vincent-gao
force-pushed
the
feature/add-mutiple_values-plugin-for-pipeline
branch
from
August 1, 2024 05:07
332a3ae
to
49864df
Compare
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://digital-vic.atlassian.net/browse/SDPAP-9391
Change
DatasetTransform
plugin calledmulti_value_processor
. The plugin splits delimited string into arrays and optionally applies a callback function to each resulting value.TideElasticSearchDestination
) that extends the baseElasticSearchDestination
plugin. The main improvements are:getFullIndexId()
method that generates the index_id based on the presence of hash prefix and regular prefix.processCleanup()
method to use the new index_id generation logic. more details see the conversation from the SlackRelated
This change has applied to https://github.com/dpc-sdp/content-solar-vic-gov-au/pull/148, just for a reference
Note on implementation approach
We've implemented this as a custom plugin rather than submitting a patch to the
data_pipelines
module. The hash code prefix functionality is specific to SDP requirements and lacks the generality needed for its upstream.Example