-
Notifications
You must be signed in to change notification settings - Fork 0
Add the base set of taxonomy to all CMS #58
base: develop
Are you sure you want to change the base?
Add the base set of taxonomy to all CMS #58
Conversation
These are the base 8 terms for searchable fields that exist in reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krakerag couple of comments and also shouldn’t this be added in the install hook as well, so that this gets added for new installed sites. The update hook does not get run in the fresh install, so for new projects it needs to be in the install hook as well.
@MdNadimHossain looks like a tide_core dependency is failing the build, is this something we are across in tide_core? |
It seems that https://www.drupal.org/project/admin_audit_trail/issues/3316835 has been fixed. Therefore, we should remove the patch from tide_core. |
The changes look great to me 👍 . Just a comment, not a request change. It should be better to use |
These are the base 8 terms for searchable fields that exist in reference, they will need to be added to all CMS as per the discussion in https://digital-vic.atlassian.net/browse/SDPAP-8338
When you run this update in reference you will get:
This is expected as the terms already exist in reference, we are ensuring they get installed in all CMS that end up with search listing for wide compatibility across the install base.