Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Add the base set of taxonomy to all CMS #58

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

krakerag
Copy link
Contributor

@krakerag krakerag commented Oct 5, 2023

These are the base 8 terms for searchable fields that exist in reference, they will need to be added to all CMS as per the discussion in https://digital-vic.atlassian.net/browse/SDPAP-8338

When you run this update in reference you will get:

> Cannot insert term Audience (Grants) as it's already present against searchable_fields vocab.
> Cannot insert term Content cateory as it's already present against searchable_fields vocab.
> Cannot insert term Department as it's already present against searchable_fields vocab.
> Cannot insert term Event category as it's already present against searchable_fields vocab.
> Cannot insert term Event requirements as it's already present against searchable_fields vocab.
> Cannot insert term Sites and site sections as it's already present against searchable_fields vocab.
> Cannot insert term Tags as it's already present against searchable_fields vocab.
> Cannot insert term Topic as it's already present against searchable_fields vocab.

This is expected as the terms already exist in reference, we are ensuring they get installed in all CMS that end up with search listing for wide compatibility across the install base.

These are the base 8 terms for searchable fields that exist in reference
Copy link
Contributor

@MdNadimHossain MdNadimHossain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krakerag couple of comments and also shouldn’t this be added in the install hook as well, so that this gets added for new installed sites. The update hook does not get run in the fresh install, so for new projects it needs to be in the install hook as well.

composer.dev.lock Outdated Show resolved Hide resolved
tide_search.install Outdated Show resolved Hide resolved
@krakerag
Copy link
Contributor Author

krakerag commented Oct 5, 2023

@MdNadimHossain looks like a tide_core dependency is failing the build, is this something we are across in tide_core?

@vincent-gao
Copy link
Contributor

vincent-gao commented Oct 5, 2023

@MdNadimHossain looks like a tide_core dependency is failing the build, is this something we are across in tide_core?

It seems that https://www.drupal.org/project/admin_audit_trail/issues/3316835 has been fixed. Therefore, we should remove the patch from tide_core.
https://github.com/dpc-sdp/tide_core/blob/develop/composer.json#L225C42-L225C42

@vincent-gao
Copy link
Contributor

The changes look great to me 👍 . Just a comment, not a request change. It should be better to use \Drupal::logger('tide_search')->notice("Cannot insert term ".$term['name']." as it's already present against searchable_fields vocab."); instead of error_log.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants