This repository has been archived by the owner on Sep 29, 2024. It is now read-only.
Added basic text enhancer. #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MdNadimHossain
requested review from
vincent-gao,
anthony-malkoun,
mayurngondhkar and
yeniatencio
vincent-gao
suggested changes
Feb 3, 2022
There was a problem hiding this comment.
@MdNadimHossain , could you please add phpunit tests into it.
MdNadimHossain
commented
Feb 22, 2022
| @@ -34,5 +34,6 @@ | |||
| # | |||
| # Uncomment and set the Dev-Tools's commit value and commit this change. | |||
| # export GH_COMMIT=COMMIT_SHA | |||
| export GH_COMMIT=a93e9347eaedfebe31970929c16d4d8b17daee3b | |||
There was a problem hiding this comment.
this needs to be removed once the dev-tools get a release with this changes - dpc-sdp/dev-tools#71
|
Thanks @MdNadimHossain for the change. LGTM |
vincent-gao
approved these changes
Feb 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://digital-engagement.atlassian.net/browse/SDPA-5895
Parent ticket - https://digital-engagement.atlassian.net/browse/SDPA-5756
Changes
Added an enhancer for basic text, which will check the pasted content from the user and strip out any unicode uneven spacing character before sending it through JSON API.
Content-vic test branch -
https://github.com/dpc-sdp/content-vic-gov-au/pull/1302