[SD-551]AV-heading-not-visible #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeniatencio
requested review from
sharmasahil,
anthony-malkoun,
vincent-gao and
MdNadimHossain
MdNadimHossain
requested changes
Dec 16, 2024
| @@ -33,6 +33,7 @@ | |||
| box-shadow: none !important; | |||
| border: none !important; | |||
| padding: 0 0 0.5em; | |||
| text-wrap: auto; | |||
There was a problem hiding this comment.
@yeniatencio auto does not actually count as a valid value anymore and it is not a global value as well. In this case you should use a valid value for text-wrap it self. In this case use text-wrap: wrap; or text-wrap: balance; or text-wrap: pretty; or text-wrap: stable;
/* Keyword values */
text-wrap: wrap;
text-wrap: nowrap;
text-wrap: balance;
text-wrap: pretty;
text-wrap: stable;
/* Global values */
text-wrap: inherit;
text-wrap: initial;
text-wrap: revert;
text-wrap: revert-layer;
text-wrap: unset;
There was a problem hiding this comment.
Thank you @MdNadimHossain . I have updated my PR.
MdNadimHossain
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://digital-vic.atlassian.net/browse/SD-551
BE link: https://nginx-php.pr-1756.content-vic.sdp4.sdp.vic.gov.au/
Problem/Motivation
Heading for AV is not fully visible:
Fix
Fixed styling by adding text-wrap property.
Related PRs
Screenshots
TODO