Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings for media alias display for documents type #557

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

sharmasahil
Copy link
Contributor

@sharmasahil sharmasahil commented Nov 27, 2024

Jira

https://digital-vic.atlassian.net/browse/SD-518

Problem/Motivation

Media library - allow alias for media items

Fix

Integrated new media file alias module with only document file type enabled. Also this module depends on media library from core which seems not enabled globally. Please advise if we can enable it too.

Related PRs

Screenshots

TODO

Copy link
Contributor

@vincent-gao vincent-gao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @sharmasahil, please take a look into my comments.

config/install/media_alias_display.settings.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@vincent-gao vincent-gao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sharmasahil . It looks like a simple change. ✅

@vincent-gao
Copy link
Contributor

ready for test

@sharmasahil
Copy link
Contributor Author

ready for test

Thanks for the approval @vincent-gao, moved it to QA, we need to still review the media_library dependency for this new module before we merge it.

@vincent-gao
Copy link
Contributor

hey @sharmasahil , could you please fix the failed build

@sharmasahil
Copy link
Contributor Author

hey @sharmasahil , could you please fix the failed build

Fixed the build.

@sharmasahil
Copy link
Contributor Author

hey @sharmasahil , could you please fix the failed build

@vincent-gao Please review the lastest commit from today for the autopublish of draft media on node publish.

Copy link
Contributor

@vincent-gao vincent-gao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @sharmasahil
ready for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants