Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated patch for search api drush cmd #551

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

sharmasahil
Copy link
Contributor

@sharmasahil sharmasahil commented Nov 25, 2024

Jira

https://digital-vic.atlassian.net/browse/SD-532

Problem/Motivation

Patch breaking on previous version of module.

Fix

Reroll patch.

Related PRs

Screenshots

TODO

composer.json Outdated Show resolved Hide resolved
@@ -37,7 +37,7 @@
"drupal/maxlength": "^2.1",
"drupal/entity_hierarchy": "4.x",
"drupal/elasticsearch_connector": "^7.0",
"drupal/search_api": "^1.11",
"drupal/search_api": "^1.36",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@anthony-malkoun anthony-malkoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharmasahil I'm a bit confused about what's going on here? This worked ok in your local build?

@sharmasahil
Copy link
Contributor Author

@sharmasahil I'm a bit confused about what's going on here? This worked ok in your local build?

Its good now, updated both paths after a test in test branch.

composer.json Outdated Show resolved Hide resolved
Copy link
Contributor

@vincent-gao vincent-gao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

@vincent-gao vincent-gao merged commit da58426 into develop Nov 25, 2024
1 check passed
@vincent-gao vincent-gao deleted the feature/SD-532-reroll-patch-searchapi branch November 25, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants