Ckedito5 patch for table cell resize #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-gao
requested changes
Nov 1, 2024
There was a problem hiding this comment.
hey @sharmasahil
do you need an update hook to apply the changes across all sites?
Also, could you clarify the need for a local patch?
Thanks for the review @vincent-gao, I have updated the PR with comments and also removed local patch, put install hook too. |
added 2 commits
November 15, 2024 15:51
vincent-gao
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
hey @sharmasahil
Just a few minor things, and it's perfectly fine if you don't want to make any changes.
please make sure build and tests pass.
|
|
||
| // Extract only the inner HTML of the <body> tag, avoiding extra tags. | ||
| $processedBodyContent = ''; | ||
| foreach ($processedDom->getElementsByTagName('body')->item(0)->childNodes as $node) { |
There was a problem hiding this comment.
can this be simplified by using DOMDocument::saveHTML directly on the element.
e.g.
$processedBodyContent = $processedDom->saveHTML($processedDom->getElementsByTagName('body')->item(0));| libxml_use_internal_errors(true); | ||
| $valueDom->loadHTML($data['value']); | ||
| $processedDom->loadHTML($data['processed']); | ||
| libxml_clear_errors(); |
...es/ckeditor_tablecol_resize/js/ckeditor5_plugins/tableColResize/src/tablecolresizeediting.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
SD-358 - Control WYSIWYG and data table column widths in ckeditor
Fix