Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-356]added content category to publication page #523

Merged

Conversation

yeniatencio
Copy link
Contributor

@yeniatencio yeniatencio commented Oct 14, 2024

Jira

https://digital-vic.atlassian.net/browse/SD-356
Testing link: https://nginx-php.pr-454.content-reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au/

Problem/Motivation

Content category section not available on publication page content type

Fix

Added content category field to publication page.

Related PRs

Screenshots

Screenshot 2024-10-15 at 4 55 42 pm

TODO

Copy link
Contributor

@MdNadimHossain MdNadimHossain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yeniatencio behat test is missing.

@yeniatencio
Copy link
Contributor Author

@yeniatencio behat test is missing.

Thanks @MdNadimHossain , I have updated my pr.

Copy link
Contributor

@MdNadimHossain MdNadimHossain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yeniatencio for the change, I hope you ran the test locally to check if it is running properly. Because after moving to mono repo it does not run the sub modules's tests automatically yet.

@yeniatencio yeniatencio merged commit e19c5a4 into develop Nov 1, 2024
4 of 6 checks passed
@yeniatencio yeniatencio deleted the feature/SD-356-add-content-category-to-publication-page branch November 1, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants