[SDPAP-8375]granted permissions to approvers to create and edit department/sites #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeniatencio
requested review from
MdNadimHossain,
krakerag,
mayurngondhkar and
vincent-gao
yeniatencio
changed the title
krakerag
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Looks like it satisfies the AC @yeniatencio - thanks for adding a test. Should we also add a test to ensure they can perform the new term creation/editing?
RonaldRinaldy
approved these changes
Jan 9, 2024
yeniatencio
deleted the
feature/SDPAP-8375-approver-restrict-delete-taxonomy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://digital-vic.atlassian.net/browse/SDPAP-8375
Testing link: https://nginx-php.pr-352.content-reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au/
Problem/Motivation
ApproverS shouldn’t be able to create/edit any taxonomy terms except Department and Sites, and shouldn’t be able to delete any taxonomy terms
Fix
Remove permissions such as administer taxonomy.
Grant permissions to create and edit terms in department
Related PRs
dpc-sdp/tide_site#144
Grant permission to create and edit sites.
Screenshots
TODO