Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the exclusion of docroot from phpcs. #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed the exclusion of docroot from phpcs. #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ INSTALL_NEW_SITE=1
# DRUPAL_REFRESH_SEARCHAPI=1

# Uncomment and add comma-separated list of targets (no spaces).
# PHPCS_TARGETS="src,tests"
# PHPCS_TARGETS="docroot/modules/custom,docroot/themes/custom,docroot/sites/default/settings.php,docroot/sites/default/envs"

# Uncomment below if Bay integration is enabled.
# BAY_INTEGRATION_ENABLED=1
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"license": "GPL-2.0-or-later",
"type": "drupal-module",
"require": {
"dpc-sdp/tide_core": "1.2.5"
"dpc-sdp/tide_core": "^1.4.0"
},
"suggest": {
"dpc-sdp/tide_media:1.2.5": "Media and related configuration for Tide Drupal 8 distribution"
"dpc-sdp/tide_media:1.3.2": "Media and related configuration for Tide Drupal 8 distribution"
}
}
8 changes: 7 additions & 1 deletion phpcs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@
key "config.platform.php".-->
<config name="testVersion" value="7.1"/>

<exclude-pattern>*/docroot/*</exclude-pattern>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this also then do everything in contrib as part of the lint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have PHPCS_TARGETS in .env

<exclude-pattern>*/docroot/*\.php</exclude-pattern>
<exclude-pattern>*/docroot/core/*</exclude-pattern>
<exclude-pattern>*/docroot/libraries/*</exclude-pattern>
<exclude-pattern>*/docroot/modules/contrib/*</exclude-pattern>
<exclude-pattern>*/docroot/profiles/*</exclude-pattern>
<exclude-pattern>*/docroot/themes/contrib/*</exclude-pattern>
<exclude-pattern>*/docroot/sites/*/files/*</exclude-pattern>
<exclude-pattern>*/console/*</exclude-pattern>
<exclude-pattern>settings.generated.php</exclude-pattern>
<exclude-pattern>*/vendor/*</exclude-pattern>
Expand Down