Added feature to log the request uri when fatal errors encountered. #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're working on reducing the PHP memory limit to ensure that we can run more concurrent workloads efficiently. There will be a period of tuning where we have to locate some areas of the application which need more memory.
Unfortunately the default php-fpm error logs do not output enough information information for us to determine what drupal routes cause a particular problem.
Changes
This PR adds a new error handler which outputs a log entry including the value of
$_SERVER['REQUEST_URI']
. This error handling is conditionally included when the following environment variable is setWhen hitting a memory exhausted error now, it should output to the php-fpm container's stdout -
Testing
Once you've got this code available on your test environment, enable the feature with the above environment variable. You can then hack in this code to settings.php below where the log file is included to induce a memory limit error.