Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure php-fpm-exporter binary is patched #323

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

nicksantamaria
Copy link
Contributor

Motivation

The https://github.com/hipages/php-fpm_exporter project is getting patches to the master branch, but there have been no new releases in 2 years.

We want a binary that does not have 2 year old CVEs running in production.

Its been pointed out in the issue queue with no response from the maintainer - hipages/php-fpm_exporter#332

There are a few forks including one from sysdig, however none have commits as recent as this project.

Changes

  • Adds a new container image called php-fpm-exporter which compiles the master branch of the git project.
  • Installs the binary on the php-fpm container from the aforementioned image, rather than the 2 year old github release.

Testing

If the build passes this should be fine.

@nicksantamaria nicksantamaria requested a review from GROwen October 31, 2024 02:05
Copy link
Contributor

@GROwen GROwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is going to be running along side the other pods I think it should be added to the bakefile so that builds occur at the same time as the other images. (also needs to be added to the IMAGES Actions var)

@nicksantamaria
Copy link
Contributor Author

@GROwen sorry I knew I had forgotten something important!! Thanks, should be fixed now.

@nicksantamaria nicksantamaria requested a review from GROwen October 31, 2024 02:18
@nicksantamaria nicksantamaria merged commit 0ce137e into 6.x Oct 31, 2024
1 check passed
@nicksantamaria nicksantamaria deleted the feature/php-fpm-metrics-patching branch October 31, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants