Update xdebug modes when xdebug is enabled #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anthony-malkoun just want to confirm that this schabge won't enable xdebug in prod? |
GROwen
approved these changes
Sep 24, 2024
@nicksantamaria no this only schabges what modes are turned on when xdebug is enabled. xdebug config has no effect if |
nicksantamaria
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The default configuration in Lagoon images when xdebug is enabled is to only enable the debug mode. This PR also enables the profile mode which will allow a tool such as QCacheGrind (
brew install qcachegrindon Mac) to analyse and display cachegrind files to identify performance and resource hotspots.Changes
[xdebug]PHP config to enable debug and profile modes.Note this change only alters what xdebug does if it is enabled.