Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scheduled scans of 5.x and 6.x images #302

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

GROwen
Copy link
Contributor

@GROwen GROwen commented Sep 10, 2024

Motivation

Refactor the trigger for vulnerability scans based on the response from GitHub support and remove the dependency on AWX to trigger the scans.

Changes

  1. Update the upload-sarif action to specify the ref and commit the scan results relate to
    • a caveat to this is that the commit will not always relate to the commit that the image was built at i.e. a breaking change on the head of 5.x will fail to build, meaning the commit used to build the image tagged 5.x and the head of the 5.x branch will no longer be the same
  2. Adds the checkout action to look up the commit of the tag input
  3. Adds specific workflows for the scheduled scans of 5.x and 6.x images

Related PRs

dpc-sdp/sdp-ansible-playbooks#176

@GROwen GROwen self-assigned this Sep 10, 2024
@GROwen GROwen added the NEEDS REVIEW Good for newcomers label Sep 10, 2024
steps:
- name: checkout
id: checkout
uses: actions/checkout@main
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm choosing to checkout the main branch of this action so I can access the ref and sha outputs which haven't been released yet.

@GROwen GROwen marked this pull request as ready for review September 10, 2024 07:42
Copy link
Contributor

@nicksantamaria nicksantamaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GROwen GROwen merged commit 0e2fcdb into 6.x Sep 10, 2024
25 checks passed
@GROwen GROwen deleted the feature/291--add-scheduled-scans branch September 10, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEEDS REVIEW Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants