Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDS-2006] Updated base branch for scan for 5.x #279

Closed
wants to merge 1 commit into from

Conversation

GROwen
Copy link
Contributor

@GROwen GROwen commented Aug 15, 2024

Run scan against only 5.x images.

@GROwen GROwen requested a review from nicksantamaria August 15, 2024 05:39
@GROwen GROwen self-assigned this Aug 15, 2024
@nicksantamaria
Copy link
Contributor

If I look at the actions tab, there are no scheduled vulnerability scans against the 5.x branch.

https://github.com/dpc-sdp/bay/actions/workflows/vulnerability-scan-schedule.yml

Is there some limitation in actions where it only runs scheduled builds against the default branch or something like that?

@GROwen
Copy link
Contributor Author

GROwen commented Aug 15, 2024

🤦 Yep, that limitation definitely exists. I'd thought that this approach would get both branches running but it will still only be the 6.x branch. I don't think it's possible to checkout one branch and then another without having separate workflows.

I'll close this PR and continue work in #280 as that will get merged to the default branch

@GROwen GROwen closed this Aug 15, 2024
@GROwen GROwen deleted the feature/DDS-2006--5.x-update-vuln-scan branch September 11, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants