[DDS-1993] Updated keys dir default file perms. #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GROwen
commented
Aug 13, 2024
| @@ -19,6 +19,11 @@ warning() { echoerr "[WARNING] $*" ; } | |||
| error() { echoerr "[ERROR] $*" ; } | |||
| fatal() { echoerr "[FATAL] $*" ; exit 1 ; } | |||
|
|
|||
| info "set umask to least permissive for SSH keys by default" | |||
There was a problem hiding this comment.
I did initially set this in a separate entrypoint script but because the change directly relates to the files generated by this entrypoint script I see no reason to abstract it further.
Another observation is that the umask value doesn't persist beyond the execution of this script. Instead the value set by the Lagoon entrypoint script 00-umask.sh does.
There was a problem hiding this comment.
I've POC'd this out and it does appear that umask is scoped to the current shell session, so subshells and scripts have their own scope.
nicksantamaria
approved these changes
Aug 13, 2024
| @@ -19,6 +19,11 @@ warning() { echoerr "[WARNING] $*" ; } | |||
| error() { echoerr "[ERROR] $*" ; } | |||
| fatal() { echoerr "[FATAL] $*" ; exit 1 ; } | |||
|
|
|||
| info "set umask to least permissive for SSH keys by default" | |||
There was a problem hiding this comment.
I've POC'd this out and it does appear that umask is scoped to the current shell session, so subshells and scripts have their own scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Explain the details for making this change. What existing problem does the pull request solve?
Changelog Entry
Improvement - Sets default file permissions in the keys directory to be less permissive.