[DDS-1993] Added ssh-client for lagoon token fetch. #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GROwen
commented
Aug 9, 2024
| @@ -1,6 +1,6 @@ | |||
| ARG PHP_VERSION=8.3 | |||
| FROM php:${PHP_VERSION}-cli-alpine AS php-cli | |||
| FROM ghcr.io/skpr/mtk:latest AS mtk | |||
| FROM ghcr.io/skpr/mtk:v2.0.2 AS mtk | |||
There was a problem hiding this comment.
@nicksantamaria The latest tag has been dropped from the registry. This is the latest "stable" tag, there is a more recent tag but it looks like it's related to a PR
There was a problem hiding this comment.
I'm fine with this 👍
nicksantamaria
approved these changes
Aug 9, 2024
| @@ -1,6 +1,6 @@ | |||
| ARG PHP_VERSION=8.3 | |||
| FROM php:${PHP_VERSION}-cli-alpine AS php-cli | |||
| FROM ghcr.io/skpr/mtk:latest AS mtk | |||
| FROM ghcr.io/skpr/mtk:v2.0.2 AS mtk | |||
There was a problem hiding this comment.
I'm fine with this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Explain the details for making this change. What existing problem does the pull request solve?
Changelog Entry
Adds ssh-client for Lagoon token fetch.
Closing issues
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).