Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDPSUP-7185] Update search endpoints to use http #264

Merged
merged 2 commits into from
May 22, 2024

Conversation

GROwen
Copy link
Contributor

@GROwen GROwen commented May 21, 2024

Changelog Entry

Updates the computed Elasticsearch endpoint used for data_pipelines to use the http protocol. This is required because the endpoint is internal to the Kubernetes cluster which does not have certificates issued for the sdp-elastic pods.

Tested in https://github.com/dpc-sdp/content-reference-sdp-vic-gov-au/pull/403

screenshots

From PR env - https://nginx-php.pr-403.content-reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au

Screenshot 2024-05-22 at 8 13 43 AM Screenshot 2024-05-22 at 8 13 55 AM

@GROwen GROwen self-assigned this May 21, 2024
@GROwen GROwen changed the title [SDPSUP-7185] Update search endpoints to use https [SDPSUP-7185] Update search endpoints to use http May 21, 2024
@GROwen GROwen added the NEEDS REVIEW Good for newcomers label May 21, 2024
Copy link

@RonaldRinaldy RonaldRinaldy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GROwen GROwen merged commit 33cbe89 into 6.x May 22, 2024
10 checks passed
@GROwen GROwen deleted the build/SDPSUP-7185--search_url-protocols branch May 22, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEEDS REVIEW Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants