-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#211] Updated tags to match workflow triggers. #212
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b611ee9
[DDS-1723] Updated tags to match workflow triggers.
GROwen 8090840
[DDS-1723] Added conditional logic to label 'source'.
GROwen 3c5d3a5
[DDS-1723] Updated development build info in README.
GROwen b3eeaca
[DDS-1723] Removed local dev reference.
GROwen 5fd0a35
[DDS-1723] Removed local dev reference.
GROwen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,14 @@ | ||
name: build-deploy-bay-images | ||
run-name: Build and deploy Bay images | ||
on: | ||
schedule: | ||
- cron: '23 20 * * 0' | ||
workflow_dispatch: | ||
pull_request: | ||
branches: | ||
- '5.x' | ||
pull_request_target: | ||
types: | ||
- closed | ||
- opened | ||
- synchronize | ||
schedule: | ||
- cron: '23 20 * * 0' | ||
workflow_dispatch: | ||
|
||
env: | ||
REGISTRY: ghcr.io | ||
|
@@ -43,24 +42,24 @@ jobs: | |
images: | | ||
${{ env.REGISTRY }}/${{ github.repository }}/${{ matrix.images }} | ||
tags: | | ||
type=ref,event=pr | ||
type=ref,event=branch | ||
type=raw,value={{github.event.pull_request.head.ref}},enable=${{ github.event.pull_request.merged == true }} | ||
type=ref,event=pr,enable=${{ github.event.pull_request.merged == false }} | ||
type=raw,value=${{ github.event.pull_request.base.ref }},enable=${{ github.event.pull_request.merged == true }} | ||
type=ref,event=branch,enable=${{ contains(fromJson('["schedule", "workflow_dispatch"]'), github.event_name) }} | ||
labels: | | ||
maintainer=Digital Victoria | ||
repository=${{ github.repositoryUrl }} | ||
org.opencontainers.image.authors=Digital Victoria | ||
org.opencontainers.image.source=https://github.com/${{ github.repository }}/tree/${{ github.ref_name }}/images/${{ matrix.images }}/Dockerfile | ||
org.opencontainers.image.source=https://github.com/${{ github.repository }}/tree/${{ (contains(fromJson('["opened","synchronize"]'), github.event.action)) && github.head_ref || github.event.action == 'closed' && github.base_ref || github.ref_name }}/images/${{ matrix.images }}/Dockerfile | ||
org.opencontainers.image.title=${{ matrix.images }} | ||
org.opencontainers.image.description=${{ matrix.images }} image for Bay container platform | ||
|
||
- name: Build and push the images | ||
if: ${{ !env.ACT }} | ||
uses: docker/[email protected] | ||
with: | ||
push: true | ||
files: | | ||
./gh-actions-bake.hcl | ||
${{ steps.meta.outputs.bake-file }} | ||
# Target the default group - probably unnecessary. | ||
# Target the default group - branchobably unnecessary. | ||
targets: ${{ matrix.images }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,12 +75,8 @@ Published images are scanned using Trivy and any CVEs identified are reported in | |
## Contribute | ||
[Open an issue](https://github.com/dpc-sdp/bay) on GitHub or submit a pull request with suggested changes. | ||
|
||
### Development Builds | ||
GitHub Actions is configured to automatically build images for pull requests that use the branch naming convention `build/<docker_image_tag>`. This will generate the tag `build-<docker_image_tag>`. | ||
|
||
For example | ||
|
||
`build/2.x-updated-cli` will generate the tag `build-2-x-updated-cli` and would be referenced as `ghcr.io/dpc-sdp/bay/<bay-image>:build-2-x-updated-cli`. | ||
### Development builds | ||
GitHub Actions is configured via the [build-deploy workflow](.github/workflows/build-deploy.yml) to build images for pull requests when they are opened and receive updates. These images are tagged with the PR number i.e. pr-86. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
## Support | ||
[Digital Engagement, Department of Premier and Cabinet, Victoria, Australia](https://github.com/dpc-sdp) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't and it's gone 😄