Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDS-1576] Remove CircleCI. Add build on merge to target. #199

Merged
merged 3 commits into from
Oct 4, 2023
Merged

[DDS-1576] Remove CircleCI. Add build on merge to target. #199

merged 3 commits into from
Oct 4, 2023

Conversation

GROwen
Copy link
Contributor

@GROwen GROwen commented Oct 3, 2023

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Changelog Entry

Change - Adds a workflow trigger for PR merges to target branch
Change - Removes CircleCI config.

@GROwen GROwen added the NEEDS REVIEW Good for newcomers label Oct 3, 2023
@GROwen GROwen requested a review from nicksantamaria October 3, 2023 06:15
@GROwen GROwen self-assigned this Oct 3, 2023
nicksantamaria
nicksantamaria requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@nicksantamaria nicksantamaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add a condition to ensure the workflow only runs when the PR is merged, not just closed.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-pull_request-workflow-when-a-pull-request-merges

@GROwen GROwen requested a review from nicksantamaria October 4, 2023 01:52
@GROwen GROwen merged commit a15ce4c into 5.x Oct 4, 2023
@GROwen GROwen deleted the feature/DDS-1576--remove-circle-checks branch October 4, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicksantamaria nicksantamaria nicksantamaria approved these changes

Assignees

@GROwen GROwen

Labels
NEEDS REVIEW Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GROwen @nicksantamaria