[R20-1508] Added datapipeline env vars. #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-gao
force-pushed
the
build/datapipeline-env-vars
branch
from
8e546ec to
4ebc87b
Compare
vincent-gao
requested review from
nicksantamaria,
steveworley,
GROwen and
anthony-malkoun
krakerag
approved these changes
Jan 15, 2024
steveworley
approved these changes
Jan 28, 2024
|
@MdNadimHossain is this change still needed? I believe Bay has moved to 6.x, if so we should change the base branch and resolve any conflicts that might come up from doing that. |
|
Is this still relevant @MdNadimHossain ? |
|
@steveworley @nicksantamaria sorry missed the comments, yes still needed. All the projects are still using 5.x, Also we need this for budget in this release. So wondering is I should merge it to 5.x and do the same change for 6.x as well ? |
merge base branch 5.x.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Explain the details for making this change. What existing problem does the pull request solve?
Changelog Entry
Closing issues
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).