Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple inline styles #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

simple inline styles #7

wants to merge 2 commits into from

Conversation

athanclark
Copy link

Hi there, I really like the feel this library gives me for designing grids, but I'd like more control over each generated element. I really like using inline styles for react components - it keeps the styling tightly coupled with the view, which I think is a good thing (for my use case at least). Would you be willing to give this freedom? If not, would you consider a height-based system? I'm not sure if you'd need to duplicate all of your width-based work in this other dimension (possibly squaring the work you need to do :P) or if we could simply hard-code some kind of fixed height. Either way, I think it would be useful.

@athanclark
Copy link
Author

After using the build in a private registry, I can confirm that this works as expected :)

@skiano
Copy link
Contributor

skiano commented Feb 22, 2016

Thanks for adding support for inline styles! I think that makes perfect sense. As for the height ideas, I am curious to know more what you are thinking about that. My instinct was that most people who would like this grid wouldn't be trying to control height that much (but it sounds like I may have missed the mark a bit).

Also, I think we should add unit tests to make sure the styles get passed through, just to make sure future changes don't remove your work. Would you be willing to add the tests? or should I take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants