Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate/confirmation-modal component #870

Open
wants to merge 7 commits into
base: 8.0.x
Choose a base branch
from

Conversation

b0ink
Copy link

@b0ink b0ink commented Aug 11, 2024

Original confirmation-modal migration PR: #846

Created a new branch from the development branch and added @s223749059's commits before making additional changes of replacing the bootstrap html with material components and a couple fixes.

Description

Migrates the confirmation-modal component from CoffeeScript to TypeScript. This component is used in the unit-tutorials-list, unit-task-editor, and portfolio-review-step components. The confirmation modal is used to display a dialog with a title, message, where users can either click cancel to dismiss the dialog, or click confirm which will run the callback function originally passed when opening the modal.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Migration

How Has This Been Tested?

  • Login as aconvenor or aadmin
  • In the top right, click Mange Units
  • Select a unit
  • Select the Tasks tab
  • Click on the delete icon to be prompted with the confirmation modal
  • Click cancel to dismiss the modal, or click Confirm to delete the unit task

Before:

confrimation-modal-before

After:

confirmation-modal-after

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@atharv02-git
Copy link

Hey, Eliya looks like the migration is done really well in terms of both code and design. The new component looks modern and keeps the original functionality intact while improving the code structure and user interface.

@b0ink b0ink marked this pull request as ready for review September 17, 2024 03:42
@b0ink b0ink changed the base branch from development to 8.0.x September 28, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants