fix: remove markdown filter from learning outcomes

doubtfire-lms · Nov 5, 2024 · 1de217c · 1de217c
1 parent b1af169
commit 1de217c
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 16 deletions.
diff --git a/src/app/config/privacy-policy/privacy-policy.ts b/src/app/config/privacy-policy/privacy-policy.ts
@@ -10,7 +10,6 @@ interface Response {
 @Injectable({
   providedIn: 'root'
 })
-
 export class PrivacyPolicy {
   privacy = '';
   plagiarism = '';
@@ -22,12 +21,12 @@ export class PrivacyPolicy {
 
     const url: string = `${this.API_URL}/settings/privacy`;
 
-    this.http
-    .get<Response>(url)
-    .subscribe(response => {
-      this.privacy = response.privacy;
-      this.plagiarism = response.plagiarism;
-      this.loaded = true;
-    });
+    this.http.get<Response>(url)
+      .subscribe(response => {
+        this.privacy = response.privacy;
+        this.plagiarism = response.plagiarism;
+        this.loaded = true;
+      }
+    );
   }
-}
+}
diff --git a/src/app/doubtfire-angularjs.module.ts b/src/app/doubtfire-angularjs.module.ts
@@ -218,7 +218,6 @@ import { ProgressBurndownChartComponent } from './visualisations/progress-burndo
 import { TaskVisualisationComponent } from './visualisations/task-visualisation/taskvisualisation.component';
 
 import {FUnitsComponent} from './admin/states/units/units.component';
-import {MarkedPipe} from './common/pipes/marked.pipe';
 import {AlertService} from './common/services/alert.service';
 
 import {GradeService} from './common/services/grade.service';
@@ -243,7 +242,6 @@ export const DoubtfireAngularJSModule = angular.module('doubtfire', [
 DoubtfireAngularJSModule.factory('AboutDoubtfireModal', downgradeInjectable(AboutDoubtfireModal));
 DoubtfireAngularJSModule.factory('DoubtfireConstants', downgradeInjectable(DoubtfireConstants));
 DoubtfireAngularJSModule.factory('ExtensionModal', downgradeInjectable(ExtensionModalService));
-DoubtfireAngularJSModule.factory('Marked', downgradeInjectable(MarkedPipe));
 DoubtfireAngularJSModule.factory('CalendarModal', downgradeInjectable(CalendarModalService));
 DoubtfireAngularJSModule.factory('TaskCommentService', downgradeInjectable(TaskCommentService));
 DoubtfireAngularJSModule.factory('alertService', downgradeInjectable(AlertService));

diff --git a/src/app/tasks/modals/upload-submission-modal/upload-submission-modal.tpl.html b/src/app/tasks/modals/upload-submission-modal/upload-submission-modal.tpl.html
@@ -167,9 +167,9 @@ <h4>
           </h4>
         </div><!--/card-heading-->
         <div class="card-body">
-          <span>
+          <p>
             {{privacyPolicy.privacy}}
-          </span>
+          </p>
           <a href="#" ng-click="showPlagiarism = !showPlagiarism">Plagiarism and collusion</a>
           <div ng-show="showPlagiarism">
             <h4>Plagiarism and Collusion</h4>

diff --git a/...asks/task-ilo-alignment/modals/task-ilo-alignment-modal/task-ilo-alignment-modal.tpl.html b/...asks/task-ilo-alignment/modals/task-ilo-alignment-modal/task-ilo-alignment-modal.tpl.html
@@ -14,7 +14,7 @@ <h3>
         <label class="text-muted" ng-show="alignment.description != null">
           Provided Rationale
         </label>
-        <div ng-bind-html="(alignment.description || 'No rationale provided') | markdown | to_trusted"></div>
+        <div ng-bind-html="(alignment.description || 'No rationale provided')"></div>
         <div class="small" ng-hide="alignment.description">Click to add one</div>
       </div>
       <div ng-if="editingRationale" class="clearfix">

diff --git a/...app/tasks/task-ilo-alignment/task-ilo-alignment-viewer/task-ilo-alignment-viewer.tpl.html b/...app/tasks/task-ilo-alignment/task-ilo-alignment-viewer/task-ilo-alignment-viewer.tpl.html
@@ -34,7 +34,7 @@ <h3 class="list-group-item-heading outcome-heading col-sm-12" style="padding: 0;
         <div class="list-group-item-text alignment-content col-sm-8" ng-show="align.expanded">
           <div ng-show="ilo.description">
             <h5>Description</h5>
-            <div class="markdown-to-html" ng-bind-html="ilo.description | markdown | to_trusted"></div>
+            <div>{{ilo.description}}</div>
           </div>
           <div ng-if="ilo && classStats &&!hideVisualisation">
             <h5>Visualisation</h5>
@@ -50,7 +50,7 @@ <h5>Visualisation</h5>
           </div>
           <div ng-show="!summaryOnly && align.description">
             <h5>Rationale</h5>
-            <div class="markdown-to-html" ng-bind-html="align.description | markdown | to_trusted"></div>
+            <div class="markdown-to-html" ng-bind-html="align.description"></div>
           </div>
           <div ng-show="summaryOnly">
             <h5>Related Tasks</h5>