-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: Update Dockerfile to use Alpine image as a base #2
Draft
kugamigh
wants to merge
5
commits into
master
Choose a base branch
from
config/update-docker-image
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1b08164
config: Update Dockerfile to use Alpine image as a base, install git,…
kugamigh f6af5f3
config: fix dockerfile and gemfile to enable build
macite d5e2f13
config: update Dockerfile to install Python dependencies
kugamigh a52e282
config: Use setup.py to install speaker-verification as a module
kugamigh 7db7cf9
config: Update Dockerfile
kugamigh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,26 @@ | ||
| FROM ruby:2.6.7-buster | ||
|
|
||
| # docker-ce-cli apt dependencies | ||
| ENV DEBIAN_FRONTEND noninteractive | ||
| RUN apt-get update | ||
|
|
||
| # TODO: Add python stuff | ||
| # Install python | ||
| RUN apt-get install -y python3 python3-pip | ||
|
|
||
| # The working location in the container is: | ||
| WORKDIR /app | ||
| # Install python/pip | ||
| # RUN python3 -m ensurepip | ||
| RUN pip3 install --no-cache --upgrade pip setuptools | ||
|
|
||
| # Get speaker-verification repo | ||
| RUN git clone https://github.com/OnTrack-UG-Squad/speaker-verification.git | ||
|
|
||
| # We need bundler to get our gems... | ||
| # Install bundler | ||
| RUN gem install bundler | ||
|
|
||
| # Now get the Gemfile and its lock... then install these gems | ||
| COPY Gemfile Gemfile.lock ./ | ||
| # Setup working dir and copy in doubtfire speaker verification code | ||
| WORKDIR /app | ||
| COPY . /app/ | ||
|
|
||
| # Install gems | ||
| RUN bundle install | ||
|
|
||
| CMD ruby app.rb | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,7 +42,7 @@ DEPENDENCIES | |
| rufo | ||
|
|
||
| RUBY VERSION | ||
| ruby 2.6.6p146 | ||
| ruby 2.7.4-r0 | ||
|
|
||
| BUNDLED WITH | ||
| 2.2.16 | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need to install any dependencies for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll need to update it to make the virtual environment and install the requirements.txt stuff, as per the main speaker-verification readme instructions.
https://github.com/OnTrack-UG-Squad/speaker-verification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than going about the virtual environment stuff, we've just gone ahead and installed the dependencies. The docker container doesn't really need things to be kept in a virtual environment from what I can see.
We have since run into problems on the speaker-verification side of things. It appears some packages have since been updated and are now causing problems which we will have to investigate.