Quality/usehashids units #373
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinstate use of the task_stats field to cache task status counts on update of target grade and tasks status. This improves performance of student query when loading a unit for staff. Co-authored-by: Tan Le <[email protected]> Co-authored-by: Ray Guo <[email protected]> Co-authored-by: talzid <[email protected]>
…ete-pid fix:fix the manual delete servers.pid file after restart container
…ms#364) refactor ternary operator which creates student_name to ensure nicknames with a value of "" are not rendered
…-unit-load-times Perf/fix project and unit load times
Currently the endpoint that handles SAML authentication is named /auth/jwt. This endpoint still exists, and there is a new endpoint called /auth/saml2 which will eventually replace the former.
Moved copied /auth/jwt and /auth/saml2 logic into a seperate file with function
Encode the ids of the units returned from /units using the hashids library. Update Gemfile and Gemfile.lock as needed.
Change authsamlhelper class to module, mark as helper for and prefix correctly Remove import authsamlhelper since helpers are imported by default
…/:id Modify unit_entity.rb to expose the id as the hashid rather than actual id, this will affect all endpoints returni ng units Modify units_api.rb to decode the hashed id for the /units/:id endpoint
sneaky-patriki
force-pushed
the
quality/usehashids_units
branch
from
699668a to
30e4b5b
Compare
…dpoints unit_by_id function which fetches a unit based on the decoded hashid This function is called in all relevant endpoints where a hashid will now be passed in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/unitsendpointQuestions
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
If you have any questions, please contact @macite or @jakerenzella.