fix: ensure test attempt review exception is handled

doubtfire-lms · Aug 9, 2024 · bb3590c · bb3590c
1 parent ccb20dc
commit bb3590c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/app/api/test_attempts_api.rb b/app/api/test_attempts_api.rb
@@ -82,7 +82,11 @@ class TestAttemptsApi < Grape::API
       error!({ message: 'Test attempt ID is invalid' }, 404)
     else
       logger.debug "Request to review test attempt #{params[:id]}"
-      test.review
+      begin
+        test.review
+      rescue StandardError => e
+        error!({ message: e.message }, 403)
+      end
     end
     present test, with: Entities::TestAttemptEntity
   end

diff --git a/app/models/test_attempt.rb b/app/models/test_attempt.rb
@@ -107,7 +107,7 @@ def cmi_datamodel=(data)
   def review
     dm = JSON.parse(self.cmi_datamodel)
     if dm['cmi.completion_status'] != 'completed'
-      raise "Cannot review incomplete attempts!"
+      raise StandardError, 'Cannot review incomplete attempts!'
     end
 
     # when review is requested change the mode to review

diff --git a/test/api/test_attempts_test.rb b/test/api/test_attempts_test.rb
@@ -215,7 +215,7 @@ def test_review_attempt
 
     # When attempt is incomplete
     get "api/test_attempts/#{attempt.id}/review"
-    assert_equal 500, last_response.status
+    assert_equal 403, last_response.status
 
     dm = JSON.parse(attempt.cmi_datamodel)
     dm['cmi.completion_status'] = 'completed'