fix 2 in checking nestTables with boolean value

doubliez · Apr 28, 2014 · 92f3758 · 92f3758
1 parent ba3ac92
commit 92f3758
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/lib/compile_binary_parser.js b/lib/compile_binary_parser.js
@@ -21,7 +21,7 @@ function compile(fields, options, config) {
   var resultTables = {};
   var resultTablesArray = [];
 
-  if (typeof options.nestTables == 'boolean') {
+  if (options.nestTables === true) {
     for (i = 0; i < fields.length; i++) {
       resultTables[fields[i].table] = 1;
     }
@@ -48,7 +48,7 @@ function compile(fields, options, config) {
     if (typeof options.nestTables == 'string') {
       tableName = srcEscape(fields[i].table);
       lvalue = ['  this[', srcEscape(fields[i].table + options.nestTables + fields[i].name), ']'].join('');
-    } else if (typeof options.nestTables === true) {
+    } else if (options.nestTables === true) {
       tableName = srcEscape(fields[i].table);
       lvalue = ['  this[', tableName, '][', fieldName, ']'].join('');
     } else if (options.rowsAsArray) {

diff --git a/lib/compile_text_parser.js b/lib/compile_text_parser.js
@@ -21,7 +21,7 @@ function compile(fields, options, config) {
   var resultTables = {};
   var resultTablesArray = [];
 
-  if (typeof options.nestTables == 'boolean') {
+  if (options.nestTables === true) {
     for (i = 0; i < fields.length; i++) {
       resultTables[fields[i].table] = 1;
     }
@@ -35,12 +35,11 @@ function compile(fields, options, config) {
   var tableName = '';
   for (i = 0; i < fields.length; i++) {
     fieldName = srcEscape(fields[i].name);
-    //debug: uncomment to see each column type in a parser source comment
     result.push('  // ' + fieldName + ': '+ typeNames[fields[i].columnType]);
     if (typeof options.nestTables == 'string') {
       tableName = srcEscape(fields[i].table);
       lvalue = ['  this[', srcEscape(fields[i].table + options.nestTables + fields[i].name), ']'].join('');
-    } else if (typeof options.nestTables === true) {
+    } else if (options.nestTables === true) {
       tableName = srcEscape(fields[i].table);
       lvalue = ['  this[', tableName, '][', fieldName, ']'].join('');
     } else if (options.rowsAsArray) {