treat 0/0/0/0/0 datetime as JS invalid time (NaN) sidorares#16

doubliez · Jul 13, 2013 · 9049f9c · 9049f9c
1 parent 832b905
commit 9049f9c
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/lib/packets/packet.js b/lib/packets/packet.js
@@ -132,6 +132,7 @@ Packet.prototype.readBuffer = function(len) {
   return this.buffer.slice(this.offset - len, this.offset);
 };
 
+var INVALID_DATE = new Date(NaN);
 // DATE, DATETIME and TIMESTAMP
 Packet.prototype.readDateTime = function(convertTtoMs) {
   var length = this.readInt8();
@@ -153,6 +154,9 @@ Packet.prototype.readDateTime = function(convertTtoMs) {
   }
   if (length > 11)
     ms = this.readInt32();
+  if ((y + m + d + H + M + S + ms) === 0) {
+    return INVALID_DATE;
+  }
   return new Date(y, m, d, H, M, S, ms);
 };
 

diff --git a/test/integration/connection/test-invalid-date-result.js b/test/integration/connection/test-invalid-date-result.js
@@ -0,0 +1,21 @@
+var common     = require('../../common');
+var connection = common.createConnection();
+var assert     = require('assert');
+
+var rows = undefined;
+
+connection.execute('SELECT TIMESTAMP(0000-00-00) t', [], function(err, _rows, _fields) {
+  if (err) throw err;
+  rows = _rows;
+});
+
+connection.end();
+
+function isInvalidTime(t) {
+  return isNaN(t.getTime());
+}
+
+process.on('exit', function() {
+  assert.deepEqual(Object.prototype.toString.call(rows[0].t), "[object Date]");
+  assert.deepEqual(isInvalidTime(rows[0].t), true);
+});