route connection time errors from handshke command to a connection. f…

…ixes sidorares#96

Changelog.md

@@ -4,6 +4,15 @@ Backlog:
   - custom typeCast handlers in generated parser             #39
 
 HEAD
+
+0.12.0 - 29/04/2014
+
+  - route connection time errors from handshke command to
+    connection                                               #96
+
+  - support for nestTables and rowsAsArray options in query()
+    and execute()                                            #95, #94
+
   - bugfix: date as parameter in prepared statement,
     day of week was used incorrectly
     instead of day of month                                  #89     ab28dfca839728dfe40d941091902185d7c19b57

lib/connection.js

@@ -96,8 +96,11 @@ function Connection(opts)
     connection.emit('error', err);
 
   });
+  var handshakeCommand;
   if (!this.config.isServer) {
-    this.addCommand(new Commands.ClientHandshake(this.config.clientFlags));
+    handshakeCommand = new Commands.ClientHandshake(this.config.clientFlags);
+    handshakeCommand.on('error', function(e) { connection.emit('error', e); });
+    this.addCommand(handshakeCommand);
   }
 }
 util.inherits(Connection, EventEmitter);

test/integration/connection/test-handshake-errors.js

@@ -0,0 +1,24 @@
+var common     = require('../../common');
+var assert     = require('assert');
+
+var conns = [];
+
+function spawn() {
+  var c = common.createConnection();
+  c.ping(spawn);
+  conns.push(c);
+
+  c.on('error', function(err) {
+    conns.forEach(function(c) { if (c) c.end(); })
+  });
+}
+
+spawn();
+
+process.on('uncaughtException', function(e) {
+  assert(false, 'should not have uncaught exceptions');
+});
+
+process.on('exit', function() {
+  assert(conns.length > 0);
+});